Skip to content

Fix 2 stale comment(s) across 1 file(s) #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LasmarKhalifa wants to merge 1 commit into
base: 07-10/doc-comment-audit-workflow
Choose a base branch
from
Draft

Fix 2 stale comment(s) across 1 file(s) #1037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/roast/cog/output.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,11 @@ def extract_number_candidates(input)
candidates.compact.uniq
end

# Normalize a number string by removing separators and currency codes and validating format
# Normalize a number string by removing separators and currency symbols and validating format
#
#: (String) -> String?
def normalize_number_string(raw)
# Remove common digit separators and currency codes
# Remove common digit separators and currency symbols
normalized = raw.strip.gsub(/[\s$¢£€¥,_]/, "")

# Validate it looks like a number (optional minus, digits, optional decimal, optional scientific notation)
Expand Down
Loading