Skip to content

[INT-6229] LMS - SAP & Workday Hub Docs Updates#256

Merged
jerann merged 2 commits into
mainfrom
int-6229/lms-sap-workday-hub-docs-updates
Aug 21, 2025
Merged

[INT-6229] LMS - SAP & Workday Hub Docs Updates#256
jerann merged 2 commits into
mainfrom
int-6229/lms-sap-workday-hub-docs-updates

Conversation

@mstrivens

@mstrivens mstrivens commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Summary by cubic

Updates SAP SuccessFactors and Workday Learning connection guides to add SAP OCN default item settings and clarify Workday permissions, including extended enterprise learners and skills, addressing INT-6229. Helps admins configure item defaults, completion behavior, and security groups correctly.

  • Documentation
    • SAP: Added defaultValues for itemType, itemCompletionStatus (with linkage note), domainID, markCompleteOnLaunch, and provider-specific overrides.
    • Workday: Split required permissions into Person/Worker Data; added optional permissions (Skills, External Learning User); updated core permissions screenshot step title; added security group action for Manage Extended Enterprise Learner.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation for two LMS integration guides: SAP SuccessFactors and Workday Learning. The changes enhance the configuration instructions with additional permission requirements and default value settings.

  • Updates Workday Learning documentation to include more granular permissions and optional configurations for extended enterprise learners and skills
  • Adds SAP SuccessFactors configuration details for setting default values for learning items including item types, completion status, and security domains

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
connection-guides/lms/workdaylearning.mdx Enhanced permissions structure with specific get-only permissions and optional configurations for extended enterprise learners
connection-guides/lms/sapsuccessfactors.mdx Added comprehensive section on configuring default values for learning items in OCN property files
Comments suppressed due to low confidence (2)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

1 issue found across 2 files • Review in cubic

Linked issue analysis

Linked issue: INT-6229: Hub Docs Updates

Status Acceptance criteria Notes
SAP: Add defaultValues.itemType[default]=value documentation and guidance Added defaultValues.itemType doc in sapsuccessfactors.mdx
SAP: Add defaultValues.itemCompletionStatus[default]=value and note that Completion Status MUST be linked to Item Type Added defaultValues.itemCompletionStatus and linkage note
SAP: Add defaultValues.domainID[default]=value documentation and guidance Added defaultValues.domainID guidance in docs
SAP: Add defaultValues.markCompleteOnLaunch[default]=value guidance (recommend 'false' if provider posts completion) Added markCompleteOnLaunch guidance and 'false' recommendation
SAP: Note provider-specific overrides using provider_name instead of default Added provider-specific override example note
Workday: Split required permissions into Person Data and Worker Data sections Reworked permission list into Person Data and Worker Data
Workday: Add Optional Permissions (Skills and External Learning User) Added 'Optional Permissions' with Skills and External Learning User
Workday: Update core permissions step title to 'The Core Permissions Should Look as Follows' Updated step title text in workdaylearning.mdx
Workday: Add security group action for 'Manage Extended Enterprise Learner (Web Service)' Added SG action instruction for Manage Extended Enterprise Learner

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.


- Choose Completion Status. E.g. COMPLETE or ONLINE-COMPL. You will need the Completion Status ID of your chosen Completion Status to replace the `value` above.

<Note>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the line is indented by four spaces, the MDX component will be rendered as plain text inside a code block rather than being evaluated, so the call-out styling will be lost.

Prompt for AI agents
Address the following comment on connection-guides/lms/sapsuccessfactors.mdx at line 293:

<comment>Because the line is indented by four spaces, the &lt;Note&gt; MDX component will be rendered as plain text inside a code block rather than being evaluated, so the call-out styling will be lost.</comment>

<file context>
@@ -275,6 +275,38 @@ To configure the OCN property file, take the following steps:
     providers[ProviderName].baseLaunchUrl=https://www.ProviderRootUrl.com
 
     providers[ProviderName].pricingModel=
+
+    #### You can also set additional default values for Learning Items:
+
+    defaultValues.itemType[default]=value
+
+    - Go to References &gt; Learning Activities &gt; Item Types &gt; Click Search. Choose an item type.
</file context>

@jerann jerann merged commit fe3cce3 into main Aug 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants