chore: sync Info.plist version with release-please releases#32
Merged
Merged
Conversation
release-please only bumps `.release-please-manifest.json` by default, so the bundle's `CFBundleShortVersionString` has been drifting (stuck at 1.1.2 while releases progressed through 1.2, 1.3, 1.4). This breaks any in-app "what version am I running" feature — including the upcoming auto-updater, which compares the bundle's version against the latest GitHub release tag. Wire `extra-files` so release-please scans `panel/Info.plist` for the `x-release-please-version` marker on every release, and bring the current value forward to 1.4.1 to match the latest tag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra-filessoCFBundleShortVersionStringinpanel/Info.plistgets bumped automatically on each release.1.1.2to1.4.1to match the latest release tag.Why
release-please only bumps
.release-please-manifest.jsonby default. The bundled app'sCFBundleShortVersionStringhas been drifting — stuck on1.1.2while releases progressed through1.2.0,1.3.0,1.4.0,1.4.1.This breaks any in-app feature that reads its own version, including the auto-updater I'm working on in
feat/notification-customization: it comparesBundle.main.infoDictionary["CFBundleShortVersionString"]against the GitHub latest-release tag, and a stale plist value means the app always thinks an update is available — even right after updating.The
x-release-please-versionmarker comment on the version line is how release-please'sgenericextra-files type identifies which string to bump.Test plan
stack-nudge.appand verifydefaults read /path/to/stack-nudge.app/Contents/Info CFBundleShortVersionStringmatches the new tag🤖 Generated with Claude Code