Repository navigation
coloc, refactor and raiss fixes - #576
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 97.73% 97.31% -0.42%
==========================================
Files 66 68 +2
Lines 25433 27711 +2278
==========================================
+ Hits 24857 26968 +2111
- Misses 576 743 +167 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danielnachun
force-pushed
the
coloc_raiss
branch
from
August 25, 2026 06:57
169c803 to
b9a49a7
Compare
danielnachun
force-pushed
the
coloc_raiss
branch
from
August 25, 2026 08:46
62309e6 to
cbb136f
Compare
danielnachun
pushed a commit
to Yining97/pecotmr
that referenced
this pull request
Aug 30, 2026
Some panels (ADSP R5) name ~3% of variants with a tag where an allele belongs (chr21:...:INS:T), so the id no longer encodes its alleles though A1/A2 are correct. Harmonization keys on the allele columns and keeps the variant; the id-string LD lookup then can't find it and aborts (.fmLdFromSketch / kriging: 'N variant id(s) not present'). The sumstats can't say which orientation was measured at such a position, so drop is the only safe choice -- the same rule StatFunGen#576's RAISS flip-pair/flip-of-known masks apply. Exclude uninterpretable-id panel entries from harmonization (.refVariantsFromSketch, so removeUnmatched drops the variant) and from RAISS (.raissUnsafeToImpute third clause), keyed on a new .ldSketchIdUsable predicate (parses to non-DNA allele; rsIDs and real indels unaffected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.