feat(engine): bracket-notation form bodies parse into nested dicts/lists - #56
Merged
Conversation
Provider SDKs POST urlencoded bodies in the Rails/PHP bracket shape (stripe-node: line_items[0][price_data][currency]=usd&…), which the flat form parser handed handlers as literal keys — body.get( "line_items") was None and every SDK-driven create 400'd. Bracket keys now expand to the nested structure handlers expect: a[b]=v -> dicts, a[]=v -> appends, a[0][b]=v -> indexed lists with merge. Malformed bracketing keeps the flat fallback; scalar/structure collisions at one path skip order-independently instead of clobbering. Found by dogfooding a real stripe-node client against stripe-style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider SDKs POST urlencoded request bodies in the Rails/PHP bracket shape — stripe-node sends
line_items[0][price_data][currency]=usd&line_items[0][quantity]=1— which the flat form parser delivered to handlers as literal flat keys, sobody.get("line_items")was None and every SDK-driven create 400'd. Found by dogfooding a real stripe-node client against the stripe-style adapter.a[b]=v→ nested dicts;a[]=v→ list appends (all repeated values);a[0][b]=v→ indexed lists with same-index merge — the shapes SDKs actually emitGates: full suite, adapter lint (94), gofmt, vet — green.