Skip to content

Update CMSIS#10

Closed
ETSells wants to merge 2 commits into
development/appafrom
feature/ES/liquids-base-fw
Closed

Update CMSIS#10
ETSells wants to merge 2 commits into
development/appafrom
feature/ES/liquids-base-fw

Conversation

@ETSells

@ETSells ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member

Description

Update CMSIS for our new HAL version.

Issue Link

Parent: SunDevilRocketry/Engine-Controller-Firmware#44

Testing

  • Passes existing unit tests
  • Unit tests modified (link the test changes as a child PR)
  • Integration test performed

Attach any test artifacts here, if relevant.

Other

Leave any additional notes here

Reviewer Checklist

Standards

  • Follows FCF Architectural Standards
  • Follows SDR Coding Standards
  • Code complexity/function Size is minimized
  • Code is testable
  • Code is readable and commented properly
  • License terms are respected

Error Handling

  • Potentially unsafe functions return a status code
  • Error returns properly handled

Memory

  • Stack allocated memory is scoped correctly
  • Heap allocated memory is avoided
  • Globally allocated memory is minimized except when necessary
  • Pointers are used correctly
  • Concurrency has been considered

Performance

  • Rate limiters are respected
  • Busy waiting is avoided
  • "Delay" calls are not used in performance sensitive code

@niekky

niekky commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

The diff is ridiculously huge so can you list out some noticeable changes from old engine lib to the one with CMSIS?

@ETSells

ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

literally just copied in a newer cmsis to replace the old. the newer HAL had an incompatibility in the ADCs which is resolved with this newer version.

@niekky

niekky commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Okay, so we will have to verify ADC works with the newer HAL but we need the wheatstone bridge pcb for this and I'm currently working on it.

@ETSells

ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

okay, heard

@ETSells

ETSells commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

bruh i forgot this existed. closing unmerged, rev 3 just pulled up CMSIS

@ETSells ETSells closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants