docs: align prose with current implementation - #36
Merged
koen-vg merged 1 commit intoJul 28, 2026
Merged
Conversation
koen-vg
force-pushed
the
chore/audit-stale-prose
branch
from
July 28, 2026 20:51
927da96 to
a233fef
Compare
koen-vg
marked this pull request as ready for review
July 28, 2026 20:54
This was referenced Jul 28, 2026
koen-vg
added a commit
that referenced
this pull request
Jul 28, 2026
The feed, food_waste, food_demand and cost steps all read `deviation_penalty.yaml`, which the stability step writes at the end of the chain. The chain is a strict forward pass, so those four were fit against whatever vintage happened to be on disk, and `tools/calibrate --check` reported them stale after every complete run. None of them needs the file. feed, food_waste and food_demand pin production to actuals via `use_actual_production` and the enforced baselines, so the deviation penalty has nothing to act on; they now disable it. The cost step drives production stability through hard bounds, and the solve resolves the `"calibrated"` sentinel only for an enabled L1 penalty -- the input declaration in `calibration_artefact_inputs` now mirrors that gate instead of keying off the sentinel alone, which drops the dependency there without a config change. The dependency was inert: regenerating both tracked sets against the current model reproduces every artefact byte-identically, and `--check` now settles all-green after a full chain. Also re-stamps both sets after #36 and #38. Neither moved the artefacts -- verified by a full re-run, not by inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pixi run -e dev docs-localpixi run -e dev lintpixi run -e dev pytest -q tests/test_extract_health_impacts.py tests/test_compute_gleam3_feed_fractions.py tests/test_sensitivity.py tests/test_manure_emissions.py(90 passed)