dpl: factor shared internal headers into private hdrs target#10426
Open
maliberty wants to merge 1 commit into
Open
dpl: factor shared internal headers into private hdrs target#10426maliberty wants to merge 1 commit into
maliberty wants to merge 1 commit into
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the src/dpl/BUILD file by extracting several private header files into a new cc_library target named dpl_private_hdrs. This target is then added as a dependency to both the dpl and ui libraries, eliminating the need to list these headers individually in their respective source lists. Feedback suggests that the new dpl_private_hdrs target is missing necessary dependencies (such as odb, utl, and Boost) and include paths required for the headers to be self-contained and compliant with layering_check.
Move the six headers that were duplicated across :dpl and :ui srcs (DplObserver.h, Coordinates.h, Grid.h, Objects.h, architecture.h, network.h) into a new :dpl_private_hdrs cc_library with //visibility:private, so they're owned in one place and unreachable from outside //src/dpl. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
openroad-ci
force-pushed
the
dpl-private-hdrs
branch
from
cd8802d to
1852990
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the six headers that were duplicated across
:dpland:uisrcs insrc/dpl/BUILD(DplObserver.h,Coordinates.h,Grid.h,Objects.h,architecture.h,network.h) into a new:dpl_private_hdrscc_librarywith//visibility:private. Both:dpland:uinow depend on it, so the headers are owned in one place and unreachable from outside//src/dpl.Type of Change
Impact
Build-system only; no behavior change. Removes header duplication across two targets in the same package while preserving
layering_checksemantics and keeping the headers package-private.Verification
bazel build //src/dpl:dpl //src/dpl:ui).Related Issues
None.