Skip to content

dpl: factor shared internal headers into private hdrs target #10426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maliberty wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −12
Open

dpl: factor shared internal headers into private hdrs target #10426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions src/dpl/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,28 @@ package(
features = ["layering_check"],
)

# Headers owned by :dpl but also consumed by :ui. Kept package-private so
# nothing outside //src/dpl can depend on them.
cc_library(
name = "dpl_private_hdrs",
hdrs = [
"src/graphics/DplObserver.h",
"src/infrastructure/Coordinates.h",
"src/infrastructure/Grid.h",
"src/infrastructure/Objects.h",
"src/infrastructure/architecture.h",
"src/infrastructure/network.h",
],
includes = ["src"],
visibility = ["//visibility:private"],
deps = [
"//src/odb/src/db",
"//src/utl",
"@boost.icl",
"@boost.utility",
],
)
Comment thread
maliberty marked this conversation as resolved.

cc_library(
name = "dpl",
srcs = [
Expand All @@ -28,20 +50,14 @@ cc_library(
"src/PlacementDRC.cpp",
"src/PlacementDRC.h",
"src/dbToOpendp.cpp",
"src/graphics/DplObserver.h",
"src/infrastructure/Coordinates.h",
"src/infrastructure/DecapObjects.h",
"src/infrastructure/Grid.cpp",
"src/infrastructure/Grid.h",
"src/infrastructure/Objects.cpp",
"src/infrastructure/Objects.h",
"src/infrastructure/Padding.cpp",
"src/infrastructure/Padding.h",
"src/infrastructure/architecture.cxx",
"src/infrastructure/architecture.h",
"src/infrastructure/detailed_segment.h",
"src/infrastructure/network.cxx",
"src/infrastructure/network.h",
"src/legalize_shift.cxx",
"src/legalize_shift.h",
"src/objective/detailed_abu.cxx",
Expand Down Expand Up @@ -87,6 +103,7 @@ cc_library(
"src",
],
deps = [
":dpl_private_hdrs",
"//src/odb/src/db",
"//src/utl",
"@boost.format",
Expand All @@ -105,14 +122,8 @@ cc_library(
name = "ui",
srcs = [
"src/MakeOpendp.cpp",
"src/graphics/DplObserver.h",
"src/graphics/Graphics.cpp",
"src/graphics/Graphics.h",
"src/infrastructure/Coordinates.h",
"src/infrastructure/Grid.h",
"src/infrastructure/Objects.h",
"src/infrastructure/architecture.h",
"src/infrastructure/network.h",
":swig",
":tcl",
],
Expand All @@ -125,6 +136,7 @@ cc_library(
],
deps = [
":dpl",
":dpl_private_hdrs",
"//:ord",
"//src/gui",
"//src/odb/src/db",
Expand Down
Loading