mpl: factor shared internal headers into private hdrs target#10428
Open
maliberty wants to merge 1 commit into
Open
mpl: factor shared internal headers into private hdrs target#10428maliberty wants to merge 1 commit into
maliberty wants to merge 1 commit into
Conversation
Move the two headers that were duplicated across :mpl and :ui srcs in src/mpl/BUILD (MplObserver.h, clusterEngine.h) into a new :mpl_private_hdrs cc_library with //visibility:private, so they're owned in one place and unreachable from outside //src/mpl. The new target declares its own deps (:pusher, //src/odb/src/db) to be self-contained. Also drop the redundant include/mpl/rtl_mp.h entry from :ui srcs (already exposed via :mpl's hdrs). Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the src/mpl/BUILD file by introducing a new cc_library target, mpl_private_hdrs, to manage shared private headers MplObserver.h and clusterEngine.h. These files were removed from the source lists of the mpl and ui libraries and are now included via dependencies, improving the build structure. I have no feedback to provide.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:mpland:uisrcs insrc/mpl/BUILD(MplObserver.h,clusterEngine.h) into a new:mpl_private_hdrscc_librarywith//visibility:private.:pusher,//src/odb/src/db) so it's self-contained rather than relying on every consumer to redeclare them.include/mpl/rtl_mp.hentry from:uisrcs (already exposed via:mpl's hdrs).Type of Change
Impact
Build-system only; no behavior change. Header duplication across two targets in the same package is eliminated while preserving
layering_checksemantics, and the private hdrs are unreachable from outside//src/mpl.Verification
bazel build //src/mpl:mpl //src/mpl:ui //src/mpl:mpl_private_hdrs).Related Issues
None.