Skip to content

mpl: factor shared internal headers into private hdrs target #10428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
May 14, 2026
+17 −5
Merged

mpl: factor shared internal headers into private hdrs target #10428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/mpl/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,31 @@ cc_library(
],
)

# Headers owned by :mpl but also consumed by :ui. Kept package-private so
# nothing outside //src/mpl can depend on them.
cc_library(
name = "mpl_private_hdrs",
hdrs = [
"src/MplObserver.h",
"src/clusterEngine.h",
],
visibility = ["//visibility:private"],
deps = [
":pusher",
"//src/odb/src/db",
],
)

cc_library(
name = "mpl",
srcs = [
"src/MplObserver.h",
"src/SACoreHardMacro.cpp",
"src/SACoreHardMacro.h",
"src/SACoreSoftMacro.cpp",
"src/SACoreSoftMacro.h",
"src/SimulatedAnnealingCore.cpp",
"src/SimulatedAnnealingCore.h",
"src/clusterEngine.cpp",
"src/clusterEngine.h",
"src/hier_rtlmp.cpp",
"src/hier_rtlmp.h",
"src/rtl_mp.cpp",
Expand All @@ -71,6 +84,7 @@ cc_library(
"include",
],
deps = [
":mpl_private_hdrs",
":pusher",
":snapper",
"//src/dbSta",
Expand All @@ -87,10 +101,7 @@ cc_library(
cc_library(
name = "ui",
srcs = [
"include/mpl/rtl_mp.h",
"src/MakeMacroPlacer.cpp",
"src/MplObserver.h",
"src/clusterEngine.h",
"src/graphics.cpp",
"src/graphics.h",
":swig",
Expand All @@ -105,6 +116,7 @@ cc_library(
],
deps = [
":mpl",
":mpl_private_hdrs",
":pusher",
"//:ord",
"//src/gui",
Expand Down
Loading