Show provider guidance in the model picker on a cold install - #116
Merged
Conversation
Screenshot verification of the merged empty-state work caught a live gap: on a machine where no provider is usable (Codex signed out, Claude not installed) the picker has no provider tabs at all, so it can only open on Favorites, and the favorites branch of the empty-state resolver returned the bare "No favorite models" before the all-providers-unavailable guidance could fire. Reorder the resolver so that when every enabled provider is unusable the per-provider status lines and the Open Settings action win regardless of the active tab.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size:S
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #114, caught by screenshot verification of the live app rather than by the test suite.
The gap
On a genuinely cold machine (Codex signed out, Claude not installed — every fresh install's starting state) the model picker renders no provider tabs at all, so Favorites is the only tab it can open on. The empty-state resolver's favorites branch returned the bare "No favorite models" before the all-providers-unavailable branch could fire — so the most important state showed the least helpful text, despite both #114 features working as unit-tested in isolation.
The fix
Reorder
resolveModelPickerEmptyState: when every enabled provider is unusable, the per-provider status lines ("Codex · Not authenticated", "Claude · Not found") and the "Open Settings" action win regardless of the active tab. "No favorite models" still shows when at least one provider is usable.Testing
vp fmt,vp lint,vp run typecheckgreen.modelPickerSearch.test.ts: 14 pass; the previous favorites-tab test now covers the usable-provider case, and a new case pins the cold-install behavior.ProviderModelPicker: 33 pass.