Skip to content

Retry transient Electron release downloads - #150

Merged
badcuban merged 1 commit into
mainfrom
fix/electron-download-retry
Aug 12, 2026
Merged

Retry transient Electron release downloads#150
badcuban merged 1 commit into
mainfrom
fix/electron-download-retry

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

What changed

  • retry Electron bootstrap downloads up to three times after thrown network failures
  • retry electron-builder packaging only when its captured failure matches a transient network signature
  • keep checksum, signing, build, and other non-network failures immediate
  • add focused coverage for recovery, bounded exhaustion, and the exact release error signatures

Why

Nightly release run 31644702203 failed while electron-builder downloaded Electron with a socket hang up. A clean workflow retry then failed in the earlier Electron bootstrap download when GitHub closed the socket. Both paths previously made one external download attempt, so a transient connection reset could prevent an otherwise green release.

Validation

  • vp fmt
  • vp lint
  • vp run typecheck
  • vp run @threadlines/scripts#test (122 tests)
  • vp run release:smoke

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
threadlines Skipped Skipped Aug 12, 2026 10:18pm

Request Review

@github-actions github-actions Bot added size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 12, 2026
@badcuban
badcuban marked this pull request as ready for review August 12, 2026 22:27
@badcuban
badcuban merged commit d825f42 into main Aug 12, 2026
13 checks passed
@badcuban
badcuban deleted the fix/electron-download-retry branch August 12, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant