fix(release): pass desktop build flags without the -- separator - #193
Merged
Conversation
vite-plus 0.3.0 (bumped in #191) forwards a literal "--" to the script instead of consuming it. The build script parses its flags with the effect CLI, which reads "--" as the end of flags, so every flag after it became an unexpected positional argument and all three nightly desktop builds failed on the first run after the bump. Drop the separator in the release and smoke workflows. Verified locally with vp 0.3.0: "vp exec vp run dist:desktop:artifact --platform bogus" now reaches the script's own validation.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size:XS
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly desktop release on 91e3635 failed in all three builds with
Unexpected positional arguments: "--platform", "linux", ....Cause: vite-plus 0.3.0 (from #191) forwards a literal
--to the script instead of consuming it.scripts/build-desktop-artifact.tsparses flags with the effect CLI, which treats--as the end of flags, so every flag after it became a positional argument.Fix: drop the
--separator inrelease.yml(Windows, macOS, Linux build steps) anddesktop-smoke.yml. No other workflow forwards script args this way.Verified locally with vp 0.3.0:
vp exec vp run dist:desktop:artifact --platform bogus --target nsisnow fails inside the script withInvalid value for flag --platform: "bogus", i.e. the flags arrive. With the--it reproduces the CI error.