Skip to content

fix(release): pass desktop build flags without the -- separator #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badcuban merged 1 commit into from
Aug 28, 2026
Merged

fix(release): pass desktop build flags without the -- separator #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/desktop-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
run: vp install --frozen-lockfile

- name: Build Linux AppImage
run: vp run dist:desktop:artifact -- --platform linux --target AppImage --arch x64 --build-version 0.2.2-smoke.0
run: vp run dist:desktop:artifact --platform linux --target AppImage --arch x64 --build-version 0.2.2-smoke.0

- name: Boot AppImage and verify backend serves
timeout-minutes: 3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ jobs:
THREADLINES_POSTHOG_HOST: ${{ vars.THREADLINES_POSTHOG_HOST }}
THREADLINES_TELEMETRY_ENABLED: ${{ vars.THREADLINES_TELEMETRY_ENABLED }}
run: >
vp exec vp run dist:desktop:artifact --
vp exec vp run dist:desktop:artifact
--platform win
--target nsis
--arch x64
Expand Down Expand Up @@ -665,7 +665,7 @@ jobs:
chmod 600 "$apple_api_key_path"
unset APPLE_API_KEY_CONTENT

APPLE_API_KEY="$apple_api_key_path" vp exec vp run dist:desktop:artifact -- \
APPLE_API_KEY="$apple_api_key_path" vp exec vp run dist:desktop:artifact \
--platform mac \
--target dmg \
--arch "${{ matrix.arch }}" \
Expand Down Expand Up @@ -807,7 +807,7 @@ jobs:
THREADLINES_POSTHOG_HOST: ${{ vars.THREADLINES_POSTHOG_HOST }}
THREADLINES_TELEMETRY_ENABLED: ${{ vars.THREADLINES_TELEMETRY_ENABLED }}
run: >
vp exec vp run dist:desktop:artifact --
vp exec vp run dist:desktop:artifact
--platform linux
--target AppImage
--arch x64
Expand Down
Loading