test(rust): verify populated acquisition withdrawal isolation - #549
Merged
Merged
Conversation
LIghtJUNction
changed the base branch from
test/rust-route-contract-coverage
to
main
September 30, 2026 08:20
LIghtJUNction
marked this pull request as ready for review
September 30, 2026 08:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #548 and #542. #542 is now merged into main at
74a455a146d9d878e9a419f3b940557d91b6c90d, and this PR has been retargeted to main. It contains one Rust test file only. Fresh post-retarget CI passed, including all five PostgreSQL tests. Merged into main at268dc3f17e968c1ee0d42736f7189f3b2ed5bf80; post-merge full CI, server qualification, and all five CodeQL analyses passed. Final main has the identical tree as the tested PR head. All five acquisition PostgreSQL tests executed successfully on main.The previous withdrawal test asserted emptiness but did not populate most tables that withdrawal must erase. Strengthen the existing PostgreSQL round-trip test to:
Self-reports remain covered by their separate explicit-delete assertion, consistent with existing Go/Rust semantics. No production code, database schema, API, frontend or Go changes. The compiled acquisition suite remains five PostgreSQL tests.
Verification
Passed locally with repository-pinned Rust 1.91.0:
cargo fmt --all --checkcargo clippy --locked -p lmm-api-rs --test acquisition -- -D warningscargo test --locked -p lmm-api-rs --test acquisition -- --skip postgres_: 2 passed; PostgreSQL cases compiled but not executed locallypython3 apps/api-rust/tests/scripts/test-new-integration-suites.py: 7 passedbash apps/api-rust/tests/scripts/check-real-integration-gates.sh: passed, 96 ignored tests across 10 modulesgit diff --checkPostgreSQL 18 integration logs for exact head 0b648702 confirm all 5 acquisition tests executed and passed (0 failed, 0 ignored), including the expanded populated-withdrawal case. Full CI run 36685526815 passed, including CI Quality Gate, Rust workspace checks, RustSec, route alignment, root-route lockfile, workflow guards and web checks.
Scope
LMM API-specific regression coverage; no issue closed. Preserves existing license/header and production semantics. No credentials or production data included.