test(rust): isolate acquisition visitor ownership - #557
Merged
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Collaborator
Author
|
Resolved in |
LIghtJUNction
force-pushed
the
test/rust-acquisition-owner-isolation
branch
from
October 1, 2026 01:07
730c891 to
e656893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged Rust acquisition coverage PRs #542, #548 and #549.
Add one isolated PostgreSQL regression test for the remaining visitor ownership and consent boundary in
PgAcquisitionStore::observe:The acquisition real-integration inventory increases from five to six tests, and the repository inventory from 96 to 97 ignored tests across ten modules.
No production code, API, schema, frontend or Go changes.
Verification
Local:
cargo fmt --all --check: passed.cargo clippy --locked -p lmm-api-rs --test acquisition -- -D warnings: passed.cargo test --locked -p lmm-api-rs --test acquisition -- --skip postgres_: 2 passed.cargo test --locked -p lmm-api-rs --test acquisition -- --ignored --list: all 6 PostgreSQL tests compiled and listed.python3 tests/scripts/test-new-integration-suites.py: 7 passed.bash tests/scripts/check-real-integration-gates.sh: passed; 97 ignored tests across 10 modules.bash -n tests/scripts/run-real-integration-gates.sh: passed.git diff --check: passed.GitHub Actions CI run 36799563426: passed.
postgres_visit_consent_and_owner_boundaries_are_atomic: passed.Coverage check
Targeted non-PostgreSQL acquisition coverage:
routes/acquisition.rs: 136/340 lines (40.00%), 15/37 functions (40.54%).routes/acquisition/data.rs: 7/221 lines (3.17%), 2/26 functions (7.69%).routes/acquisition/store.rs: 3/428 lines (0.70%), 1/43 functions (2.33%).The local coverage command excludes the ignored PostgreSQL suite, so the store percentage does not credit this new database test; the CI PostgreSQL gate provides the execution evidence for the ownership/rollback path.