test(rust): cover acquisition link lifecycle - #563
Merged
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
LIghtJUNction
commented
Oct 2, 2026
LIghtJUNction
left a comment
Collaborator
Author
There was a problem hiding this comment.
Two regression-coverage gaps in the new lifecycle test, identified from the assertions and current store implementation:
LIghtJUNction
force-pushed
the
test/rust-acquisition-link-lifecycle
branch
from
October 3, 2026 00:46
003ff31 to
49571e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged Rust acquisition coverage PR #557.
Add one isolated PostgreSQL regression test for the remaining promotion-link storage lifecycle in
PgAcquisitionStore:nameandarchived; attribution fields and creation time remain immutable.save_link.LIKEwildcards (_and%).The acquisition PostgreSQL inventory increases from six to seven tests, and the repository real-integration inventory from 97 to 98 ignored tests across ten modules.
The branch is rebased on current
mainand contains one commit. Both review threads about persisted-state and pagination assertions are addressed and resolved.No production code, API, schema, frontend or Go changes.
Verification
Local:
cargo fmt --all --check: passed.cargo clippy --locked -p lmm-api-rs --test acquisition -- -D warnings: passed.cargo test --locked -p lmm-api-rs --test acquisition -- --skip postgres_: 2 passed.cargo test --locked -p lmm-api-rs --test acquisition -- --ignored --list: all 7 PostgreSQL tests compiled and listed.python3 tests/scripts/test-new-integration-suites.py: 7 passed.bash tests/scripts/check-real-integration-gates.sh: passed; 98 ignored tests across 10 modules.bash -n tests/scripts/run-real-integration-gates.sh: passed.git diff --check: passed.GitHub Actions CI run 37083490347: passed.
postgres_link_updates_filters_searches_and_deletes_are_durable: passed.Coverage check
Targeted non-PostgreSQL acquisition coverage:
routes/acquisition.rs: 136/340 lines (40.00%), 15/37 functions (40.54%).routes/acquisition/data.rs: 7/221 lines (3.17%), 2/26 functions (7.69%).routes/acquisition/store.rs: 3/428 lines (0.70%), 1/43 functions (2.33%).The local coverage command excludes ignored PostgreSQL tests, so the store percentage does not credit this database test; the successful PostgreSQL 18 gate provides execution evidence for the persisted update and pagination paths.