feat: chrome translation — write flow (4 screens) - #45
Merged
Conversation
Adds Japanese, Simplified Chinese, and Traditional Chinese keys to the four writing-entry screens: - WriteScreen.tsx - FreeWriteScreen.tsx - FreeWriteChoiceScreen.tsx - ExpressiveWriteScreen.tsx ~30 t()/bilingual() sites total. Cherry-picked from the larger sweep branch (feat/chrome-translation-tier2-3) as a per-flow reviewable PR following the PR #44 pattern. Register: polite Japanese (です・ます), neutral Mandarin (S/T distinguished where they differ — 继续/繼續, 书写/書寫). Native review pass still planned post-merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Japanese, Simplified Chinese, and Traditional Chinese keys to the four writing-entry screens so users never silently fall back to English mid-session.
Files (~30
t()/bilingual()sites total):WriteScreen.tsxFreeWriteScreen.tsxFreeWriteChoiceScreen.tsxExpressiveWriteScreen.tsxCherry-picked from the larger sweep branch (
feat/chrome-translation-tier2-3) as a per-flow reviewable PR, same pattern as #44.Translation samples
Back→戻る/返回/返回Free Write→自由に書く/自由书写/自由書寫Don't worry about mistakes.→間違いは気にしないでください。/别担心错误。/別擔心錯誤。What kind of writing?→どんな書き方にしますか?/想要哪种写作?/想要哪種寫作?Take a moment to breathe.→少し深呼吸しましょう。/稍作停顿,深呼吸一下。/稍作停頓,深呼吸一下。Register: polite Japanese (です・ます), neutral Mandarin with S/T distinguished where they differ (继续/繼續, 书写/書寫). Native review pass still planned post-merge.
Test plan
tsc --noEmitpassesvitest run— 14 files / 198 tests passCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com