Skip to content

Fix: Wrap hardcoded strings in i18n translation helpers #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EForce11 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Wrap hardcoded strings in i18n translation helpers #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b64abe
Fix: Wrap hardcoded strings in i18n translation helpers
EForce11 Jan 28, 2026
48f1757
Fix: Correct indentation and remove translation from email placeholder
EForce11 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion partials/components/featured.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{#get "posts" filter="featured:true" include="authors" limit=limit as |featured|}}
<section class="gh-featured gh-outer">
<div class="gh-featured-inner gh-inner">
<h2 class="gh-featured-title">Featured</h2>
<h2 class="gh-featured-title">{{t "Featured"}}</h2>
<div class="gh-featured-feed">
{{#foreach featured}}
{{> "post-card" imageSizes="80px"}}
Expand Down
2 changes: 1 addition & 1 deletion partials/components/footer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{{navigation type="secondary"}}
</nav>
<div class="gh-footer-copyright">
Powered by <a href="https://ghost.org/" target="_blank" rel="noopener">Ghost</a>
{{t "Powered by"}} <a href="https://ghost.org/" target="_blank" rel="noopener">Ghost</a>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion partials/components/header-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<h1 class="gh-header-title is-title">{{#if @custom.header_text}}{{@custom.header_text}}{{else}}{{@site.description}}{{/if}}</h1>
<form class="gh-form">
{{> "icons/search"}}
<button class="gh-form-input" data-ghost-search>Search posts, tags and authors</button>
<button class="gh-form-input" data-ghost-search>{{t "Search posts, tags and authors"}}</button>
</form>
{{/match}}

Expand Down
10 changes: 5 additions & 5 deletions partials/components/navigation.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{{/if}}
</a>
{{> "search-toggle"}}
<button class="gh-burger gh-icon-button" aria-label="Menu">
<button class="gh-burger gh-icon-button" aria-label="{{t 'Menu'}}">
{{> "icons/burger"}}
{{> "icons/close"}}
</button>
Expand All @@ -35,15 +35,15 @@
<div class="gh-navigation-members">
{{#unless @member}}
{{#unless @site.members_invite_only}}
<a href="#/portal/signin" data-portal="signin">Sign in</a>
<a href="#/portal/signin" data-portal="signin">{{t "Sign in"}}</a>
{{#unless hideSubscribeButton}}
<a class="gh-button" href="#/portal/signup" data-portal="signup">Subscribe</a>
<a class="gh-button" href="#/portal/signup" data-portal="signup">{{t "Subscribe"}}</a>
{{/unless}}
{{else}}
<a class="gh-button" href="#/portal/signin" data-portal="signin">Sign in</a>
<a class="gh-button" href="#/portal/signin" data-portal="signin">{{t "Sign in"}}</a>
{{/unless}}
{{else}}
<a class="gh-button" href="#/portal/account" data-portal="account">Account</a>
<a class="gh-button" href="#/portal/account" data-portal="account">{{t "Account"}}</a>
{{/unless}}
</div>
{{/unless}}
Expand Down
12 changes: 6 additions & 6 deletions partials/components/post-list.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

{{#if showTitle}}
<h2 class="gh-container-title">
{{#unless title}}Latest{{else}}{{title}}{{/unless}}
{{#unless title}}{{t "Latest"}}{{else}}{{title}}{{/unless}}
</h2>
{{/if}}

Expand Down Expand Up @@ -80,7 +80,7 @@

{{#match pagination.pages ">" 1}}
<div class="gh-more is-title">
<a href="{{@site.url}}/page/2">See all {{> "icons/arrow"}}</a>
<a href="{{@site.url}}/page/2">{{t "See all"}} {{> "icons/arrow"}}</a>
</div>
{{/match}}
</main>
Expand All @@ -98,21 +98,21 @@
{{/if}}
{{#if @site.members_enabled}}
{{#unless @member}}
<button class="gh-button" data-portal="signup">Subscribe</button>
<button class="gh-button" data-portal="signup">{{t "Subscribe"}}</button>
{{else}}
{{#if @site.paid_members_enabled}}
{{#unless @member.paid}}
<button class="gh-button" data-portal="upgrade">Upgrade</button>
<button class="gh-button" data-portal="upgrade">{{t "Upgrade"}}</button>
{{/unless}}
{{/if}}
{{/unless}}
{{/if}}
</section>
{{#if @site.recommendations_enabled}}
<section class="gh-recommendations">
<h4 class="gh-sidebar-title">Recommendations</h4>
<h4 class="gh-sidebar-title">{{t "Recommendations"}}</h4>
{{recommendations}}
<button data-portal="recommendations">See all {{> "icons/arrow"}}</button>
<button data-portal="recommendations">{{t "See all"}} {{> "icons/arrow"}}</button>
</section>
{{/if}}
</div>
Expand Down
4 changes: 2 additions & 2 deletions partials/email-subscription.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<form class="gh-form" data-members-form>
<input class="gh-form-input" id="{{email_field_id}}" name="email" type="email" placeholder="jamie@example.com" required data-members-email>
<button class="gh-button" type="submit" aria-label="Subscribe">
<span><span>Subscribe</span> {{> "icons/arrow"}}</span>
<button class="gh-button" type="submit" aria-label="{{t 'Subscribe'}}">
<span><span>{{t "Subscribe"}}</span> {{> "icons/arrow"}}</span>
{{> "icons/loader"}}
{{> "icons/checkmark"}}
</button>
Expand Down
12 changes: 6 additions & 6 deletions partials/lightbox.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<div class="pswp__top-bar">
<div class="pswp__counter"></div>

<button class="pswp__button pswp__button--close" title="Close (Esc)"></button>
<button class="pswp__button pswp__button--share" title="Share"></button>
<button class="pswp__button pswp__button--fs" title="Toggle fullscreen"></button>
<button class="pswp__button pswp__button--zoom" title="Zoom in/out"></button>
<button class="pswp__button pswp__button--close" title="{{t 'Close (Esc)'}}"></button>
<button class="pswp__button pswp__button--share" title="{{t 'Share'}}"></button>
<button class="pswp__button pswp__button--fs" title="{{t 'Toggle fullscreen'}}"></button>
<button class="pswp__button pswp__button--zoom" title="{{t 'Zoom in/out'}}"></button>

<div class="pswp__preloader">
<div class="pswp__preloader__icn">
Expand All @@ -30,8 +30,8 @@
<div class="pswp__share-tooltip"></div>
</div>

<button class="pswp__button pswp__button--arrow--left" title="Previous (arrow left)"></button>
<button class="pswp__button pswp__button--arrow--right" title="Next (arrow right)"></button>
<button class="pswp__button pswp__button--arrow--left" title="{{t 'Previous (arrow left)'}}"></button>
<button class="pswp__button pswp__button--arrow--right" title="{{t 'Next (arrow right)'}}"></button>

<div class="pswp__caption">
<div class="pswp__caption__center"></div>
Expand Down
2 changes: 1 addition & 1 deletion partials/post-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
{{/has}}
{{/unless}}<!--
-->{{#if @custom.show_author}}
<span class="gh-card-author">By {{#foreach authors}}{{#if @first}}{{name}}{{else}}, {{name}}{{/if}}{{/foreach}}</span>
<span class="gh-card-author">{{t "By"}} {{#foreach authors}}{{#if @first}}{{name}}{{else}}, {{name}}{{/if}}{{/foreach}}</span>
{{/if}}
{{#if @custom.show_publish_date}}
<time class="gh-card-date" datetime="{{date format="YYYY-MM-DD"}}">{{date format="DD MMM YYYY"}}</time>
Expand Down
2 changes: 1 addition & 1 deletion partials/search-toggle.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<button class="gh-search gh-icon-button" aria-label="Search this site" data-ghost-search>
<button class="gh-search gh-icon-button" aria-label="{{t 'Search this site'}}" data-ghost-search>
{{> "icons/search"}}
</button>
2 changes: 1 addition & 1 deletion post.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
{{#if next}}
<section class="gh-container is-grid gh-outer">
<div class="gh-container-inner gh-inner">
<h2 class="gh-container-title">Read more</h2>
<h2 class="gh-container-title">{{t "Read more"}}</h2>
<div class="gh-feed">
{{#foreach next}}
{{> "post-card" lazyLoad=true}}
Expand Down