feat(nav): execute arrival actions when robot reaches a POI#111
Closed
xiaolefang-dm wants to merge 2 commits intomainfrom
Closed
feat(nav): execute arrival actions when robot reaches a POI#111xiaolefang-dm wants to merge 2 commits intomainfrom
xiaolefang-dm wants to merge 2 commits intomainfrom
Conversation
Adds an optional `actions` field to POI definitions. When the robot arrives at a POI, map_node runs the action sequence before advancing to the next waypoint. POIs without actions behave exactly as before. Supported action types (tinynav/core/action_executor.py): - lookat: rotate to face a map-frame coordinate - wait: pause for N seconds - photo: save latest keyframe image to disk - custom: publish arbitrary command to /service/command New action types can be registered in ACTION_REGISTRY without touching map_node or the POI schema. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional actions field to POI definitions. When the robot arrives at a POI, it executes the action sequence
before advancing to the next waypoint. POIs without actions are completely unaffected.
Why
Navigation to a POI is just half the story — the robot often needs to do something meaningful when it gets there (face
a direction, take a photo, wait). Without this, every use case requires custom code. This gives a clean, declarative
way to attach behaviors to POIs without touching the nav stack.
How it works
pois.json → map_node.pois_data → arrive at POI → action_executor → advance
New file: tinynav/core/action_executor.py
Self-contained, no new dependencies.
Adding a new action type = one async def + one line in ACTION_REGISTRY. No changes to map_node or POI schema needed.
Example pois.json
Backward compatibility
Fully backward compatible. Existing pois.json without actions work as before — no migration needed.