docs: sidecar decode-sink keep + 0122 per-output gate#104
Merged
Conversation
Bring docs in line with shipped #41 behavior (v1.7.0). REWRITER.md still described the decode-sink strip as unconditional; it is gated on file_idx==0 (embedded) with sidecar bindings (file_idx>=1) keeping Plex's null-mux. PACED_SELF_DECODE.md still described the whole-decoder sink_less gate; patch 0122 refined it to per-output to avoid the dual-consumer SIGSEGV. Replaces stale PR #44 (CHANGELOG hunk dropped — release-please owns it; #41/#43 already documented in the v1.7.0 section). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings two docs in line with the shipped #41 behavior (released in v1.7.0). Replaces the stale PR #44 (43 commits behind
main, hard CHANGELOG conflict).-map ... -f null -codec assdecode-sink strip is conditional (stripInlineassDecodeSink, gated onfile_idx == 0), not unconditional. Sidecar bindings (file_idx >= 1) keep Plex's null-mux so the sidecar demuxer has a real consumer.start_prepare()sink-less gate is per-output (fork patch0122), not whole-decoder; documents the dual-consumer SIGSEGV the original variant caused.Why a new PR instead of #44
## Unreleased(gone since v1.7.0→v1.9.1 shipped) → the conflict. CHANGELOG is release-please's territory; dropped.worker/agent/rewriter.go:1216is stillfile_idx-gated).Test plan
stripInlineassDecodeSinkimplementation🤖 Generated with Claude Code