docs: post-merge updates for PR #41 + #43#44
Closed
Varashi wants to merge 1 commit into
Closed
Conversation
CHANGELOG: - Fix PR ref #40 -> #41 on the existing HW-decode-text orthogonal entry. - Add fork patch 0122 (sched-sinkless-per-output) — the bug 0120 introduced in start_prepare for the dual-consumer case + the per-output gate fix. - Add the rewriter sidecar-sink-keep fix — gate stripInlineassDecodeSink on file_idx==0, combined with 0122 closes sidecar SRT regression. - Add PR #43 tryOptimizeRemux fold (already-merged). REWRITER.md: clarify that stripInlineassDecodeSink is conditional now (embedded strip, sidecar keep) — the previous wording asserted unconditional strip. PACED_SELF_DECODE.md: refine the 0120 start_prepare description to note the per-output gate (0122) — original whole-decoder `continue` broke dst_finished allocation for real consumers in dual-consumer mode. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
Owner
Author
|
Superseded by #104. This branch was 43 commits behind main with a hard CHANGELOG conflict — release-please already documented #41/#43 in the v1.7.0 section, so the CHANGELOG hunk here is obsolete. The two still-valid doc fixes (REWRITER.md decode-sink conditional strip + PACED_SELF_DECODE.md 0122 per-output gate) are re-done cleanly off current main in #104. |
Varashi
added a commit
that referenced
this pull request
May 29, 2026
Bring docs in line with shipped #41 behavior (v1.7.0). REWRITER.md still described the decode-sink strip as unconditional; it is gated on file_idx==0 (embedded) with sidecar bindings (file_idx>=1) keeping Plex's null-mux. PACED_SELF_DECODE.md still described the whole-decoder sink_less gate; patch 0122 refined it to per-output to avoid the dual-consumer SIGSEGV. Replaces stale PR #44 (CHANGELOG hunk dropped — release-please owns it; #41/#43 already documented in the v1.7.0 section). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates documentation to reflect the merged PR #41 (HW-decode-text orthogonal + fork patch 0122 + rewriter sidecar-sink-keep) and PR #43 (tryOptimizeRemux fold).
Changes
stripInlineassDecodeSinkis conditional now (embedded strip / sidecar keep), not unconditional.start_preparedescription now notes the 0122 per-output gate refinement.Self-contained. No behavior change.
🤖 Generated with Claude Code