Port dead store elimination pass from #3858#8456
Open
stevenfontanella wants to merge 8 commits intomainfrom
Open
Port dead store elimination pass from #3858#8456stevenfontanella wants to merge 8 commits intomainfrom
stevenfontanella wants to merge 8 commits intomainfrom
Conversation
stevenfontanella
force-pushed
the
binaryen-dse
branch
3 times, most recently
from
ef50399 to
f0e3ee2
Compare
stevenfontanella
force-pushed
the
binaryen-dse
branch
from
f738f72 to
129a6db
Compare
stevenfontanella
changed the title
stevenfontanella
force-pushed
the
binaryen-dse
branch
from
e27e635 to
5714f71
Compare
stevenfontanella
requested review from
kripken and
tlively
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from #3858. Dead store elimination for memories is removed from #3858 because it now seems to incorrectly optimize away some live stores on memory when the offset doesn't match (this was not the case in the PR that this is based on but it's not clear why), rough repro.
Diff of DeadStoreElimination.cpp from original PR: https://editor.mergely.com/Z6sNkKse
Diff of ldse.wast from the original PR: https://editor.mergely.com/T2ScMPzF
My latest analysis showed that this didn't have a large effect on a large candidate binary. Land this anyway as an experimental pass.