-
Notifications
You must be signed in to change notification settings - Fork 843
Port dead store elimination pass from #3858 #8456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevenfontanella
wants to merge
10
commits into
main
Choose a base branch
from
binaryen-dse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,889
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9123225
Pull in DSE branch
stevenfontanella 9217cb6
Some fixes
stevenfontanella aaef9df
More fixes
stevenfontanella 7833ff3
update lit test after rebase
stevenfontanella 2f5c1f9
Remove MemoryLogic
stevenfontanella 58f18e1
Some small changes
stevenfontanella 129a6db
Add more tests
stevenfontanella 5714f71
Add support for trapsNeverHappen
stevenfontanella 23fd316
PR updates
stevenfontanella 6197eb7
Remove comment
stevenfontanella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright 2026 WebAssembly Community Group participants | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef wasm_ir_replacer_h | ||
| #define wasm_ir_replacer_h | ||
|
|
||
| #include <wasm-traversal.h> | ||
| #include <wasm.h> | ||
|
|
||
| namespace wasm { | ||
|
|
||
| // A map of replacements to perform on expressions. After filling the map, | ||
| // simply do a walk(..) and they will be replaced. | ||
| // | ||
| // This is useful for a general replacement of expressions. Some passes can | ||
| // store pointers to expressions and update only those, but then there is the | ||
| // nesting problem, | ||
| // | ||
| // (foo | ||
| // (bar | ||
| // (baz | ||
| // | ||
| // If we replace bar with something then the pointer to baz may change. Doing | ||
| // the replacements in the order of a walk, as is done here, is always safe. | ||
| struct ExpressionReplacer | ||
| : PostWalker<ExpressionReplacer, | ||
| UnifiedExpressionVisitor<ExpressionReplacer>> { | ||
| std::unordered_map<Expression*, Expression*> replacements; | ||
|
|
||
| void visitExpression(Expression* curr) { | ||
| auto iter = replacements.find(curr); | ||
| if (iter != replacements.end()) { | ||
| replaceCurrent(iter->second); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| } // namespace wasm | ||
|
|
||
| #endif // wasm_ir_replacer_h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long have you fuzzed this? (If not, let's not add it here)