Skip to content

Expose Snakemake generation of APE to RestfulAPE#95

Merged
eladrion merged 3 commits into
mainfrom
bump_to_ape_2_6
Feb 26, 2026
Merged

Expose Snakemake generation of APE to RestfulAPE#95
eladrion merged 3 commits into
mainfrom
bump_to_ape_2_6

Conversation

@eladrion

@eladrion eladrion commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Pull Request Overview

This PR updates RestAPE by depending on APE 2.6.1 and exposing Snakemake files generated by APE

Related Issue

Changes Introduced

RestAPE now triggers the generation of Snakemake files. Also, the Snakemake files are added to the workflow ZIP file
and the Snakemake files are retrievable separately

How Has This Been Tested?

  • Local testing with test suite.
  • Local testing using cURL, i.e. generating solutions, calling POST method snakemake
  • Tested with updated Workflomics-frontend on private institutional instance at UP

Checklist

  • I have referenced a related issue.
  • I have followed the project’s style guidelines.
  • My changes include tests, if applicable.
  • All tests pass locally.
  • I have added myself to the CITATION.cff file, if not already present.

@vedran-kasalica vedran-kasalica left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eladrion, the changes look good, and it's nice that you also improved the JavaDocs in the process!

The only observation (similar to the one in workflomics PR #111 is that it might be rare that a user wants a zip file that includes both cwl and snakemake files. Maybe the request can have parameters that determine what is returned. Or zip could include folders based on the availability, e.g., if 0 cwl files were requested in the configuration file the zip should not include the cwl folder.

@eladrion

eladrion commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi @vedran-kasalica, I like the idea of optional subfolders depending on requested and existing language specific outputs. I will implement this as a separate PR and it will also become part of v1.1.

@vedran-kasalica

Copy link
Copy Markdown
Member

Thanks @eladrion, sounds great! Feel free to merge this PR in that case

@eladrion

Copy link
Copy Markdown
Contributor Author

Hi @vedran-kasalica. Issue created for subfolders. Merging now.

@eladrion eladrion merged commit de99e70 into main Feb 26, 2026
2 checks passed
@eladrion eladrion deleted the bump_to_ape_2_6 branch February 26, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Snakemake export supported by the current APE version

2 participants