fix(hu): name the hu target in the default log filter - #317
Merged
Merged
Conversation
The binary target is named `hu`, so every `tracing::` call in the hiroz-union crate emits under the `hu` target. The default filter named only `hiroz` and `zenoh`, so with RUST_LOG unset the host's own warnings were emitted and then discarded before reaching a terminal. The whole fix is one string literal. A unit test asserts the defaults name the target and parse, because nothing else would catch its removal.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1 of 5, splitting #311. Independent of the other four.
What this does
Adds the
hutarget to the default log filter.What fails without this
The binary target is named
hu, so everytracing::call inhiroz-unionemits under thehutarget. The default filter named onlyhirozandzenoh. WithRUST_LOGunset, the host emitted its own warnings and then discarded them.hiroz=info,zenoh=warnhu=info,hiroz=info,zenoh=warn--debughiroz=debug,zenoh=debughu=debug,hiroz=debug,zenoh=debugRUST_LOGunsetRUST_LOGsetThe whole fix is one string literal, which is the kind of line a later edit drops without noticing.
defaults_name_the_hu_target_and_parseasserts both defaults name the target and parse.Breaking changes
None. A user who sets
RUST_LOGsees no change.