fix(hu): use axum 0.8 wildcard route syntax in hu web - #318
Merged
Merged
Conversation
The plugin routes used the axum 0.7 form `*path`. `Router::route` validates path syntax by panicking at run time, not at compile time, so this compiled cleanly and aborted `hu web` the moment anyone started it. Router construction moves into `build_router` so a test can exercise it without a Zenoh session or a bound socket. Building the router is the check: wrong path syntax panics there.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 2 of 5, splitting #311. Independent of the other four.
What this does
Uses axum 0.8 wildcard route syntax in
hu web, and adds a test that builds the router.What fails without this
The routes used the axum 0.7 form
*path.Router::routevalidates path syntax by panicking at run time, not at compile time.hu webstartupPath segments must not start with '*'The command was documented and shipped, and nothing caught it, because
web-pluginsis not a default feature and CI never compiled it.Router construction moves into
build_routerso a test can exercise it without a Zenoh session or a bound socket. Building the router is the check: wrong path syntax panics there.Important
The test only exists under
--features web-plugins. Without that flag the samecargo testinvocation reports0 passed; 13 filtered outand exits 0. Any CI job meant to cover this must pass the feature, or it is green over nothing.Breaking changes
None.