feat(hiroz): let the examples advertise their message types - #320
Merged
Merged
Conversation
YuanYuYuan
force-pushed
the
fix/hu-epoch-budget
branch
from
August 21, 2026 12:17
1a6629d to
aa68097
Compare
YuanYuYuan
force-pushed
the
feat/hiroz-type-desc-optin
branch
from
August 21, 2026 12:17
542c04b to
49d9162
Compare
YuanYuYuan
force-pushed
the
feat/hiroz-type-desc-optin
branch
from
August 21, 2026 13:27
49d9162 to
52d29dc
Compare
A plain hiroz node does not serve the type description service unless it asks. rclcpp and rclpy serve it by default, and hiroz's own RMW layer forces it on, so the examples were the only nodes on a hiroz graph that runtime-typed consumers could not decode: `hu meter echo`, dynamic subscribers and bridges all had no schema to obtain. Every publishing example now opts in, and `ZNodeBuilder` documents why you probably want to. Two additions the plugin host needs from outside the crate: `ZLifecycleNodeBuilder::with_type_description_service()`, so lifecycle publishers register their schemas too, and `ros_type_name_from_dds`, which becomes public so out-of-crate consumers normalise graph-reported type names the same way rather than re-deriving it. Rider: z_pubsub's nodes are renamed `Sub`/`Pub` to `listener`/`talker`. That is a user-visible rename, not a type-description change, and the docs always claimed the new names.
YuanYuYuan
force-pushed
the
feat/hiroz-type-desc-optin
branch
from
August 21, 2026 14:12
52d29dc to
207339b
Compare
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 4 of 5, splitting #311. Sits on #319; #311 sits on this.
What this does
Makes the hiroz examples advertise their message types, and exposes the two library items an out-of-crate plugin host needs.
What fails without this
A plain hiroz node does not serve the type description service unless it asks. rclcpp and rclpy serve it by default, and hiroz's own RMW layer forces it on for every node it creates, so the examples were the only nodes on a hiroz graph that a runtime-typed consumer could not decode.
hu meter echoagainst oneZNodeBuilder::with_type_description_serviceTwo additive library items, no default changed:
ZLifecycleNodeBuilder::with_type_description_service()hiroz::dynamic::ros_type_name_from_ddsBreaking changes
z_pubsubnode namesSub/Pubtolistener/talkerThis is a rider: it is a rename, not a type-description change. It is two lines, and separating it would make a one-line pull request.
Verification
cargo build -p hiroz --examplesproduces a binary for all eight edited examples. Three of them are nested files whose Cargo target names differ from their filenames —demo_nodes_talker,lifecycle_talker,z_cache_talker— so a check keyed on the filename reports a false miss.