Clamp page size to a minimum of one - #72
Merged
Merged
Conversation
PageParameter clamped the page to 0 and the size to MAX_PAGE_SIZE, but a size below 1 passed through unchanged. toPageRequest then called PageRequest.of, which throws IllegalArgumentException for a size below one. In consuming applications a request with size=0 ended in an unhandled exception instead of a corrected page request. The size is now clamped to a minimum of 1, with a warn log in the same style as the existing maximum clamp. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PageParameterclamps the page to 0 and the size toMAX_PAGE_SIZE, but a size below 1 passes through unchanged.toPageRequest()then callsPageRequest.of, which throwsIllegalArgumentExceptionfor a size below one. In consuming applications a request withsize=0or a negative size ends in an unhandled exception (HTTP 500) instead of a corrected page request.Fix
The size is now clamped to a minimum of 1, with a warn log in the same style as the existing maximum clamp. This matches how the page is already clamped to 0.
Tests
New
PageParameterTestcovers the defaults for null values, the page clamp, both size clamps (minimum and maximum), and thattoPageRequest()succeeds for a zero size.🤖 Generated with Claude Code