Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,13 @@ private PageParameter(@Nullable Integer page, @Nullable Integer size) {
if (actualSize > MAX_PAGE_SIZE) {
log.warn("Page size exceeded maximum [actualSize={}, maxSize={}]", actualSize, MAX_PAGE_SIZE);
}
if (actualSize < 1) {
log.warn("Page size below minimum [actualSize={}, minSize=1]", actualSize);
}

pageInfo = new PageInfo(
Math.max(0, actualPage),
Math.min(actualSize, MAX_PAGE_SIZE),
Math.min(Math.max(1, actualSize), MAX_PAGE_SIZE),
true
);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package it.aboutbits.springboot.toolbox.parameter;

import org.jspecify.annotations.NullMarked;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

@NullMarked
class PageParameterTest {
@Test
void shouldUseDefaults_forNullPageAndSize() {
// when
var parameter = PageParameter.of(null, null);

// then
assertThat(parameter.page()).isZero();
assertThat(parameter.size()).isEqualTo(PageParameter.DEFAULT_PAGE_SIZE());
}

@Test
void shouldClampPageToZero_forNegativePage() {
// when
var parameter = PageParameter.of(-5, 10);

// then
assertThat(parameter.page()).isZero();
}

@Test
void shouldClampSizeToMaximum_forSizeAboveMaximum() {
// when
var parameter = PageParameter.of(0, PageParameter.MAX_PAGE_SIZE() + 1);

// then
assertThat(parameter.size()).isEqualTo(PageParameter.MAX_PAGE_SIZE());
}

@Test
void shouldClampSizeToOne_forZeroSize() {
// when
var parameter = PageParameter.of(0, 0);

// then
assertThat(parameter.size()).isEqualTo(1);
}

@Test
void shouldClampSizeToOne_forNegativeSize() {
// when
var parameter = PageParameter.of(0, -10);

// then
assertThat(parameter.size()).isEqualTo(1);
}

@Test
void shouldCreateValidPageRequest_forZeroSize() {
// when
var pageRequest = PageParameter.of(0, 0).toPageRequest();

// then
assertThat(pageRequest.getPageNumber()).isZero();
assertThat(pageRequest.getPageSize()).isEqualTo(1);
}
}