sysShutdown: shorten per-row Source File paths (follow-up to #345)#346
Merged
Conversation
Unused imports removed, constant f-strings fixed, loop-variable leak guarded with an initializer, legacy-signature args pragma'd. Note: this artifact has v2 metadata but a legacy self-reporting body (no artifact_processor, no LAVA output) - conversion flagged separately.
Collaborator
|
@abrignoni this may not need changed as it can probably get deleted in favor of using iLEAPP for Sysdiagnose extractions. I don't recall why we had it here also |
pull Bot
pushed a commit
to f0r3ns1cat0r/RLEAPP
that referenced
this pull request
Jul 6, 2026
Closes out the RLEAPP LAVA conversion: sysShutdown had v2 metadata (legacy 'function' key) but a self-reporting body with no LAVA output. Split into two artifact_processor artifacts matching the original reports — Sysdiagnose - Shutdown Log Processes (Timestamp/Entry Number/PID/Path/ Source File) and Sysdiagnose - Shutdown Log Reboots (Timestamp/Reboot Number/Source File) — sharing one verbatim parse helper. - context form, output_types standard, Timestamp typed datetime (UTC via convert_ts_int_to_utc; drops the no-op convert_utc_human_to_timezone 'UTC' wrap) - per-row Source File stays extraction-relative via context.get_relative_path (preserves abrignoni#346 behavior) - preserves @KevinPagano3 attribution and 2024-02-13 creation date - pylint --disable=C,R 10.00; loader 312 -> 313; fixture-tested via .__wrapped__ (per-file entry/reboot numbering unchanged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart of ALEAPP #932 / iLEAPP row-level fix: wraps the
file_foundcopies placed in per-record Source File columns withContext.get_relative_path. Full RLEAPP audit found only this file as a true positive — google_health already emits basenames, and kik.py is deliberately deferred to avoid conflicting with the open migration PR #287 (it should adopt relative paths as part of that rework).pylint 10.00/10; byte-compile clean.