Report extraction-relative source paths from artifact_processor#1656
Merged
Conversation
Mirror of ALEAPP #931: artifacts overwhelmingly return the raw absolute on-disk path as source_path, leaking the examiner's local filesystem into HTML report headers and LAVA metadata. Shorten centrally in the decorator: each newline-separated segment passes through Context.get_relative_path, which returns its input unchanged when the data_folder prefix is absent (literals, already-relative paths, runs without a data_folder). Also clears the file's pre-existing lint debt (9.57 -> 10.00) with zero-behavior-change treatments: explicit datetime imports, local renames for shadowed names, dead pass/unused-var cleanups, no-interpolation f-string fixes, a reworded fixme, and inline pragmas where changing public API signatures or exception behavior would risk compatibility.
This was referenced Jul 6, 2026
abrignoni
added a commit
that referenced
this pull request
Jul 6, 2026
Shorten per-row Source File paths (follow-up to #1656) + dmss data_list fix
Slay3r00
pushed a commit
to Slay3r00/iLEAPP
that referenced
this pull request
Jul 6, 2026
Follow-up to abrignoni#1656 (central source_path shortening): these artifacts also place the absolute on-disk path inside a per-record Source File column. Wrap the row-inserted copy with context.get_relative_path. - appItunesmeta: parent directory of the iTunesMetadata plist - voiceTriggers: the info json path - dmss: the media file path; also fixes a pre-existing bug where the function returned data_headers twice, discarding the built data_list entirely (the artifact output its own headers as rows). Audit note: all other flagged candidates were verified false positives - BeReal, burnerCache, discord_cache, tikTok, discordChats, walStrings, mobileInstallb, sysShutdown and booking already shorten via their own helpers or emit device-side paths/basenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of ALEAPP #931:
artifact_processornow passes every returnedsource_paththroughContext.get_relative_path()(per newline segment), so reports show extraction-relative paths instead of the examiner's local filesystem. Passthrough semantics keep literals, already-relative paths, and no-data_folder runs untouched.Also clears
ilapfuncs.py's pre-existing lint debt (9.57 → 10.00, 35 messages) with zero-behavior-change treatments, same approach as the ALEAPP PR — explicit datetime imports, shadowed-name local renames, dead-code removal, f-string fixes, and inline pragmas where API params (id,type,source_file) or exception semantics must stay untouched.Testing: shorten-logic unit tests pass (relative, literal, multi-path); pylint 10.00/10; byte-compile; PluginLoader registers all plugins;
timezone/datetime/timedeltare-exports verified intact.Row-level Source File column sweep for iLEAPP to follow separately (as in ALEAPP #932).