Skip to content

🧪 Add tests for GetFamilyNames and refactor implementation#14

Open
adcondev wants to merge 4 commits into
masterfrom
jules-3930117566554857831-dab2c751
Open

🧪 Add tests for GetFamilyNames and refactor implementation#14
adcondev wants to merge 4 commits into
masterfrom
jules-3930117566554857831-dab2c751

Conversation

@adcondev

@adcondev adcondev commented Jun 1, 2026

Copy link
Copy Markdown
Owner

🎯 What: The GetFamilyNames function in internal/service/registry.go was hardcoded and lacking tests.
📊 Coverage: Added a test (TestGetFamilyNames) verifying that GetFamilyNames returns the keys from GetServiceRegistry() in sorted order, covering its intended behaviour completely.
Result: The GetFamilyNames function is now dynamic and is fully tested.


PR created automatically by Jules for task 3930117566554857831 started by @adcondev

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

⚡ Benchmark Results

⚠️ No benchmarks found in the current codebase.

To add benchmarks, create functions starting with Benchmark in *_test.go files.

adcondev and others added 2 commits June 1, 2026 00:50
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant