🧪 Add tests for GetFamilyNames and refactor implementation

internal/service/registry.go

@@ -1,6 +1,8 @@
 package service
 
 import (
+	"sort"
+
 	"github.com/adcondev/poster-tuis/internal/assets"
 	"github.com/adcondev/poster-tuis/internal/config"
 )
@@ -57,7 +59,13 @@ func GetServiceRegistry() map[string][]Variant {
 	}
 }
 
-// GetFamilyNames returns the ordered list of service family identifiers
+// GetFamilyNames returns a sorted list of available service families.
 func GetFamilyNames() []string {
-	return []string{"scale", "ticket"}
+	reg := GetServiceRegistry()
+	names := make([]string, 0, len(reg))
+	for name := range reg {
+		names = append(names, name)
+	}
+	sort.Strings(names)
+	return names
 }

internal/service/registry_test.go

@@ -0,0 +1,33 @@
+package service
+
+import (
+	"reflect"
+	"sort"
+	"testing"
+)
+
+func TestGetFamilyNames(t *testing.T) {
+	// Call the function
+	names := GetFamilyNames()
+
+	// Get the registry to compare
+	reg := GetServiceRegistry()
+
+	// 1. Verify the length
+	if len(names) != len(reg) {
+		t.Fatalf("GetFamilyNames() returned %d items, expected %d", len(names), len(reg))
+	}
+
+	// 2. Verify all keys from the registry are present
+	expectedNames := make([]string, 0, len(reg))
+	for name := range reg {
+		expectedNames = append(expectedNames, name)
+	}
+
+	// 3. Verify it is sorted
+	sort.Strings(expectedNames)
+
+	if !reflect.DeepEqual(names, expectedNames) {
+		t.Errorf("GetFamilyNames() = %v, want %v", names, expectedNames)
+	}
+}

internal/ui/builders.go

@@ -9,6 +9,13 @@ import (
 	"github.com/adcondev/poster-tuis/internal/service"
 )
 
+const (
+	actionBack      = "back"
+	actionForceStop = "force-stop"
+	titleVolver     = "Volver"
+	iconBack        = "[<]"
+)
+
 // ══════════════════════════════════════════════════════════════
 // Menu Item Type
 // ══════════════════════════════════════════════════════════════
@@ -91,10 +98,10 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 				data:        "install-remote",
 			},
 			menuItem{
-				title:       "Volver",
+				title:       titleVolver,
 				description: "Regresar al menú principal",
-				icon:        "[<]",
-				data:        "back",
+				icon:        iconBack,
+				data:        actionBack,
 			},
 		}
 	}
@@ -130,15 +137,15 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 			title:       "Forzar Detención",
 			description: "El servicio está en transición — forzar detención",
 			icon:        "[!]",
-			data:        "force-stop",
+			data:        actionForceStop,
 		})
 
 	case service.StatusUnknown:
 		items = append(items, menuItem{
 			title:       "Forzar Detención",
 			description: "Estado desconocido — intentar forzar detención del servicio",
 			icon:        "[!]",
-			data:        "force-stop",
+			data:        actionForceStop,
 		})
 	default:
 		log.Printf("Estado inesperado para %s: %s", installed, status.String())
@@ -159,10 +166,10 @@ func buildFamilyMenuItems(fs service.FamilyStatus) []list.Item {
 			data:        "uninstall",
 		},
 		menuItem{
-			title:       "Volver",
+			title:       titleVolver,
 			description: "Regresar al menú principal",
-			icon:        "[<]",
-			data:        "back",
+			icon:        iconBack,
+			data:        actionBack,
 		},
 	)
 
@@ -189,10 +196,10 @@ func buildLogsMenuItems() []list.Item {
 			data:        "open-dir",
 		},
 		menuItem{
-			title:       "Volver",
+			title:       titleVolver,
 			description: "Regresar al menú de servicio",
-			icon:        "[<]",
-			data:        "back",
+			icon:        iconBack,
+			data:        actionBack,
 		},
 	}
 }

internal/ui/update.go

@@ -211,7 +211,7 @@ func (m Model) handleFamilyKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 		}
 
 		switch selected.data {
-		case "back":
+		case actionBack:
 			return m.goToDashboard()
 
 		case "install-local":
@@ -236,7 +236,7 @@ func (m Model) handleFamilyKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			}
 			return m.executeAction("Detener Servicio", mgr.Stop)
 
-		case "force-stop":
+		case actionForceStop:
 			mgr := m.getActiveManager()
 			if mgr == nil {
 				m.statusMessage = "No se pudo determinar el servicio a detener."
@@ -313,7 +313,7 @@ func (m Model) handleLogsKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			m.statusMessage = "Abriendo carpeta de logs..."
 			return m, nil
 
-		case "back":
+		case actionBack:
 			return m.returnToFamilyMenu()
 		}
 	}