add zero code exemples for CrewAI#101
add zero code exemples for CrewAI#101ossama-ferjani wants to merge 1 commit intoagentevals-dev:mainfrom
Conversation
| "Is the number you rolled prime?", | ||
| ] | ||
|
|
||
| for i, query in enumerate(test_queries, 1): |
There was a problem hiding this comment.
Are you sure this would work? I think you either have to use memory or use a single Crew to make sure you can engage in a multi-turn conversation.
When adding new examples, please make sure to use the best practices and conventions of the framework in use to make these as useful starting points as possible.
|
|
||
| opentelemetry-sdk>=1.36.0 | ||
| opentelemetry-exporter-otlp-proto-http>=1.36.0 | ||
| opentelemetry-instrumentation-crewai>=0.40.0 |
There was a problem hiding this comment.
This is an old version of the openllmetry library. You might need to opt-in for new semconv, or we have to add support for the legacy conventions by doing this #88. Can you please explore the options here and do some testing?
There was a problem hiding this comment.
I'll take a look at this as well
There was a problem hiding this comment.
@krisztianfekete ok just tested some version sequencly and 0.56.0 is the boundary version with new semconv (quick fix), but if upgrading to this version can cause a dependancy conflict!
For the related issue can't we just add a fallback chain pattern in extraction.py to use lagacy conventions and ofc change what's needed
so what do you think?
There was a problem hiding this comment.
Can you please elaborate on the dependency conflict?
Regardless, I'd see if we can do OTEL_SEMCONV_STABILITY_OPT_IN, or wait until we do #88.
| verbose=True, | ||
| ) | ||
|
|
||
| test_queries = [ |
There was a problem hiding this comment.
Can you please make the this a 3 turn conversation like it is for all existing examples for consistency?
| endpoint = os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT", "http://localhost:4318") | ||
| print(f"OTLP endpoint: {endpoint}") | ||
|
|
||
| os.environ["OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT"] = "true" |
There was a problem hiding this comment.
Please use setdefault.
3 participants
fix #41