feat(podcontract): deliver CUDA tools and enable opt-in preload - #334
Draft
galletas1712 wants to merge 1 commit into
Draft
galletas1712 wants to merge 1 commit into
galletas1712 wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This was referenced Sep 16, 2026
galletas1712
added this pull request to stack #339
September 16, 2026 22:37
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 16, 2026 23:51
ace5dba to
699e03b
Compare
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
2 times, most recently
from
September 17, 2026 07:39
16d3f11 to
d235d0a
Compare
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 17, 2026 08:52
d235d0a to
223ac67
Compare
galletas1712
removed this pull request from stack #339
September 17, 2026 08:53
galletas1712
added this pull request to stack #343
September 17, 2026 08:53
1 task
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 17, 2026 09:30
223ac67 to
0299d1b
Compare
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 17, 2026 20:53
0299d1b to
25e328c
Compare
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 17, 2026 22:39
25e328c to
9e43a17
Compare
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
2 times, most recently
from
September 18, 2026 01:51
3707874 to
98bd929
Compare
Refs #295. Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
galletas1712
force-pushed
the
schwinns/cuinterpose-rust-09-pod-contract
branch
from
September 18, 2026 03:41
98bd929 to
80d659c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #295 (approved).
Deliver CUDA tools at fixed paths, reserve the per-container control directory, and enable the shim through the cuinterpose annotation.
Review boundary
Do not select a content backend or decide whether to wrap a command based on GPU count. Existing shared jobfile declarations survive only until their remaining callers are removed in the following slices.
This PR contains one signed-off commit,
0299d1b7dbb9609d57e6e4da87b66c38657a0825. Diff: 4 files changed, 492 insertions(+), 1 deletion(-).Use
slices.EqualFuncfor the tool-mount comparison while preserving the exact fields compared.Stack and compatibility
The stack starts directly on
main; it does not depend on the PageBroker GPU-transfer branch or #323. The shim only saves shared creator bytes through host carriers. Never-shared allocations remain native CUDA state. The stack removes launch-job/jobfile support, and older jobfile-dependent or draft shim artifacts are rejected rather than migrated.PageBroker and native CustomStorage changes are separate. No PR in this stack adds that implementation.
Validation
Validation of the assembled implementation:
make checkin a clean disposable worktree.GLM testing without CustomStorage was cancelled at the user's request and is not a pass. GLM qualification uses a separate composition with CustomStorage; previous experimental GLM results are not qualification of this rebuilt stack. The installed test driver is not claimed to be a stock-driver qualification.
Tests above were run on the assembled implementation, not claimed independently for every source-only intermediate PR. The standard-library cleanup was validated with Rust workspace tests and strict Clippy, GNU/musl builds and packaged fake-driver tests, plus targeted pod-contract and CUDA-agent Go tests. Physical-GPU tests were not rerun for this cleanup; the earlier GPU results above remain attributed to the pre-cleanup implementation.