Fix mobile keyboard and grid flicker#196
Merged
Merged
Conversation
almogdepaz
force-pushed
the
fix/mobile-keyboard-grid-polish
branch
8 times, most recently
from
July 22, 2026 08:04
366b806 to
4fbcffb
Compare
almogdepaz
force-pushed
the
fix/mobile-keyboard-grid-polish
branch
from
July 22, 2026 09:13
4fbcffb to
88f603d
Compare
almogdepaz
marked this pull request as draft
July 22, 2026 09:31
almogdepaz
marked this pull request as ready for review
July 22, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#terminal-viewso keyboard positioning does not fight mobile view/swipe transformsVerification
bun run typecheckbun test tests/unit/desktop-terminal-logic.test.ts tests/unit/kb-accessory-layout.test.tsbunx playwright test tests/e2e/session-switch.e2e.ts --project=iphone-14 --grep "keyboard viewport shift|mobile card swipe peek|mobile touch scrolling"bunx playwright test tests/e2e/grid.e2e.ts --project=desktop --grep "addToGrid|grid topology add|forceRepaint"GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false bun testbunx playwright test