fix(acct-types): use digest Output alias#1872
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1872 +/- ##
==========================================
+ Coverage 80.05% 80.07% +0.01%
==========================================
Files 685 685
Lines 77937 77937
==========================================
+ Hits 62391 62406 +15
+ Misses 15546 15531 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@peter941221 CI is failing you need to format your code. |
|
Pushed 21e45bd to fix the formatting failure in crates/acct-types/src/util.rs.\n\nI reran cargo fmt --all --check on the PR branch in WSL, and it passes now. I also reran cargo test -p strata-acct-types --lib -- --nocapture in a Linux-side WSL copy because this repo's SSZ build inputs still hit the known CRLF trap from /mnt/c checkouts, and that package test passed there. |
Description
Replaces
digest::generic_array::GenericArraywithdigest::Outputincrates/acct-types/src/util.rs.The old import path is deprecated in the current
digeststack, and in this workspace's SP1 guest toolchain that warning was enough to trigger an ICE during releaseprover-perfguest builds. This keeps the helper behavior the same while moving to the public alias.Type of Change
Notes to Reviewers
This is intentionally split out of
#1868so the checkpoint fixture PR stays about benchmark realism rather than guest toolchain compatibility.The diff is a type-alias substitution only.
compute_codec_digestandcompute_codec_sha256keep the same behavior.AI was used to assist in this PR.
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues