Skip to content

fix(acct-types): use digest Output alias#1872

Open
peter941221 wants to merge 2 commits into
alpenlabs:mainfrom
peter941221:fix/acct-types-digest-output
Open

fix(acct-types): use digest Output alias#1872
peter941221 wants to merge 2 commits into
alpenlabs:mainfrom
peter941221:fix/acct-types-digest-output

Conversation

@peter941221
Copy link
Copy Markdown

@peter941221 peter941221 commented May 28, 2026

Description

Replaces digest::generic_array::GenericArray with digest::Output in crates/acct-types/src/util.rs.

The old import path is deprecated in the current digest stack, and in this workspace's SP1 guest toolchain that warning was enough to trigger an ICE during release prover-perf guest builds. This keeps the helper behavior the same while moving to the public alias.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

This is intentionally split out of #1868 so the checkpoint fixture PR stays about benchmark realism rather than guest toolchain compatibility.

The diff is a type-alias substitution only. compute_codec_digest and compute_codec_sha256 keep the same behavior.

AI was used to assist in this PR.

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

@peter941221 peter941221 marked this pull request as ready for review May 29, 2026 10:16
Copy link
Copy Markdown
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you.

@bewakes
Copy link
Copy Markdown
Contributor

bewakes commented Jun 1, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.07%. Comparing base (3524605) to head (94eac4c).
⚠️ Report is 15 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   80.05%   80.07%   +0.01%     
==========================================
  Files         685      685              
  Lines       77937    77937              
==========================================
+ Hits        62391    62406      +15     
+ Misses      15546    15531      -15     
Flag Coverage Δ
functional 59.59% <0.00%> (+0.35%) ⬆️
unit 66.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/acct-types/src/util.rs 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli
Copy link
Copy Markdown
Member

@peter941221 CI is failing you need to format your code.

@peter941221
Copy link
Copy Markdown
Author

Pushed 21e45bd to fix the formatting failure in crates/acct-types/src/util.rs.\n\nI reran cargo fmt --all --check on the PR branch in WSL, and it passes now. I also reran cargo test -p strata-acct-types --lib -- --nocapture in a Linux-side WSL copy because this repo's SSZ build inputs still hit the known CRLF trap from /mnt/c checkouts, and that package test passed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants