Skip to content

fix(prover-core): drive remote proving on a long-lived runtime#1949

Merged
storopoli merged 2 commits into
mainfrom
paas-service-not-ready
Jun 8, 2026
Merged

fix(prover-core): drive remote proving on a long-lived runtime#1949
storopoli merged 2 commits into
mainfrom
paas-service-not-ready

Conversation

@evgenyzdanovich
Copy link
Copy Markdown
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e05762a963

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prover-core/src/strategy.rs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Commit: 8c7dd21

SP1 Execution Results

program cycles gas
EVM EE Chunk 824,732 969,395
EVM EE Account 404,056 498,593
Checkpoint 2,601,525 3,007,269

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.43%. Comparing base (7f26448) to head (2846c69).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/prover-core/src/strategy.rs 0.00% 17 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
+ Coverage   84.42%   84.43%   +0.01%     
==========================================
  Files         637      637              
  Lines       76510    76682     +172     
==========================================
+ Hits        64592    64749     +157     
- Misses      11918    11933      +15     
Flag Coverage Δ
functional 66.37% <0.00%> (-0.02%) ⬇️
unit 69.75% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/prover-core/src/strategy.rs 11.92% <0.00%> (-1.48%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@purusang purusang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible based on recent observations. ]

Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e05762a

I'm a little suspicious on the hard-coded 2 threads for the rt, but it is fine for now. We can revisit later.

@storopoli storopoli enabled auto-merge June 8, 2026 12:15
@storopoli storopoli added this pull request to the merge queue Jun 8, 2026
@evgenyzdanovich evgenyzdanovich removed this pull request from the merge queue due to a manual request Jun 8, 2026
@evgenyzdanovich evgenyzdanovich enabled auto-merge June 8, 2026 12:21
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2846c69

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Jun 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 8, 2026
@storopoli storopoli added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 9fc92da Jun 8, 2026
30 of 31 checks passed
@storopoli storopoli deleted the paas-service-not-ready branch June 8, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants