deps: bump the splat-renderer fork to upstream 8.0.1 - #38
Merged
Merged
Conversation
Repoints `[patch.crates-io]` at the §1-11 edit set replayed onto upstream
8.0.1 (rev f94855a4 -> ffaecd70), and follows the version requirement in
`Cargo.toml`. Two upstream commits come in:
* #236 — the 8.0.1 version bump
* #237 — the `lazy_type_alias` -> `checked_type_aliases` nightly
feature-gate rename, which is exactly the fix we were carrying as fork
edit §11. That edit is now a docs-only entry instead of a code
divergence, so the fork is one edit closer to upstream.
Also folded in: upstream's `chunks_exact` -> `as_chunks` modernisation in
`query/raycast.rs` and its test/tool code.
The rebase was verified rather than trusted: replaying `martin-tightcut`
onto `upstream/main` locally reproduces the pinned commit's tree
byte-for-byte, and diffing that commit against upstream leaves only our
seven edited files (CHANGES.md, settings.rs, io/scene.rs,
morph/interpolate.wgsl, render/{bindings,gaussian}.wgsl, render/mod.rs) —
no shader behaviour change.
Caveat recorded next to the pin: the rebased head currently lives on the
fork's `martin-tightcut-rebased` branch; `martin-tightcut` still points at
the 8.0.0 base and wants a force-with-lease fast-forward.
Nothing else was behind. `cargo update` moves zero packages: Bevy 0.19.1,
wgpu 29.0.4, resvg 0.48.1, image 0.25.10, clap 4.6.6, fundsp 0.23.0 — every
direct dependency is already at its latest published version. The toolchain
pin stays at nightly-2026-08-28 (two days old, whole-tree verified, carries
the measured next-solver opt-out); re-rolling it buys nothing.
Verified: fmt, clippy -D warnings, 176 tests, reuse lint, sh3 profile check,
strict score validate, the intro --features bundle single binary, and a real
headless render on software Vulkan (lavapipe) — probe frame plus
pipeline/smoke-shows.py intro, all three probes non-black.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PKfeksSyvpsfwgeq8noKu8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints
[patch.crates-io]at the §1–11 edit set replayed onto upstream 8.0.1 (f94855a4→ffaecd70), and follows the version requirement inCargo.toml. No martin source changes; no shader behaviour change.What comes in
Two upstream commits:
lazy_type_alias→checked_type_aliasesnightly feature-gate rename, which is exactly the fix we were carrying as fork edit §11. That edit is now a docs-only entry instead of a code divergence, so the fork is one edit closer to upstream.Also folded in: upstream's
chunks_exact→as_chunksmodernisation inquery/raycast.rsand its test/tool code.The rebase was verified, not trusted
The rebased head already existed on the fork, pushed by an automated session a couple of hours earlier, so it was re-derived rather than taken at face value:
martin-tightcutontoupstream/mainlocally reproduces the pinned commit's tree byte-for-byte.CHANGES.md,gaussian/settings.rs,io/scene.rs,morph/interpolate.wgsl,render/bindings.wgsl,render/gaussian.wgsl,render/mod.rs— with all §1–11 edits intact and zero conflicts.The pinned rev currently lives on the fork's
martin-tightcut-rebasedbranch;martin-tightcutstill points at the 8.0.0 base. This session had no push access toannejan/bevy_gaussian_splatting, so the canonical branch wants a fast-forward:Do not delete
martin-tightcut-rebasedbefore that — the pinned rev would become unfetchable and fresh checkouts would break. A note to this effect sits next to the pin inCargo.toml.The fork's own
CHANGES.mdis also now stale in two places: the header still says "upstream 8.0.0", and §11 still ends "Upstream (mosure) will need the same fix" — it has since landed as #237.Nothing else was behind
cargo updatemoves zero packages. Every direct dependency is already at its latest published version — Bevy 0.19.1, wgpu 29.0.4, resvg 0.48.1, image 0.25.10, clap 4.6.6, fundsp 0.23.0, rayon 1.12.0, serde_json 1.0.151. The only crate in the tree behind a newer release isgeneric-array0.14.7, held there transitively (1.x is a breaking rewrite). The SHA-pinned Actions are Dependabot-managed (last grouped bump 2026-08-28, #35), and.cargo/audit.tomlstill needs only the onettf-parserunmaintained-crate ignore.The toolchain pin stays at
nightly-2026-08-28, deliberately. Newer nightlies exist, but that pin is two days old, was whole-tree verified, and carries the measured-Znext-solver=coherenceopt-out; re-rolling it for two days of churn buys nothing and risks the compo build.Verification
Every CI gate, run locally and green:
cargo fmt --all --checkcargo clippy --all-targets -- -D warningscargo test --releasereuse lint--no-default-features --features sh3)MARTIN_SCORE_STRICT=1)--features bundlesingle binaryPlus a real headless render through software Vulkan (lavapipe), which is stronger than CI's own smoke job — that one usually goes inconclusive on the free runners:
t=2renders the deFEEST logo correctly, with bloom.pipeline/smoke-shows.py intro— all three probes non-black (mean=40.4 / 49.9 / 6.2,lit=0.397 / 0.537 / 0.047).Generated by Claude Code