Skip to content

Pass handle array storage to Vulkan enumeration and allocation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antono3 merged 4 commits into from
Sep 24, 2026
Merged

Pass handle array storage to Vulkan enumeration and allocation #61

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edd964e
Fix fragment shading rate callback array parameters
antono2 Sep 24, 2026
37ec219
Pass handle array storage to Vulkan enumeration and allocation
Sep 24, 2026
e7adf53
Revert "Fix fragment shading rate callback array parameters"
Sep 24, 2026
f0ddd2a
Merge branch 'master' of https://github.com/antono2/vulkan into fix/v…
Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ergonomic/ergonomic.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ pub fn (pool &OwnedCommandPool) allocate_primary(count u32) ![]&PrimaryCommandBu
commandBufferCount: count
}
mut handles := unsafe { []vk.CommandBuffer{len: int(count)} }
require_success(vk.allocate_command_buffers(pool.device, &allocate_info, handles.data),
require_success(vk.allocate_command_buffers(pool.device, &allocate_info, unsafe { &handles[0] }),
'vkAllocateCommandBuffers')!

mut buffers := []&PrimaryCommandBuffer{cap: int(count)}
Expand Down Expand Up @@ -825,14 +825,15 @@ pub fn (instance &OwnedInstance) physical_devices() ![]PhysicalDevice {
}

mut handles := unsafe { []vk.PhysicalDevice{len: int(count)} }
result := vk.enumerate_physical_devices(instance.handle, &count, handles.data)
result := vk.enumerate_physical_devices(instance.handle, &count, unsafe { &handles[0] })
if result == .incomplete {
continue
}
require_success(result, 'vkEnumeratePhysicalDevices(values)')!

mut devices := []PhysicalDevice{cap: int(count)}
for handle in handles[..int(count)] {
for index in 0 .. int(count) {
handle := handles[index]
mut properties := vk.PhysicalDeviceProperties{}
vk.get_physical_device_properties(handle, mut properties)
devices << PhysicalDevice{
Expand Down
Loading