create placeholder facts if they're None when creating relationships#3248
Merged
Conversation
|
1 similar comment
|
|
❌ The last analysis has failed. |
1 similar comment
|
❌ The last analysis has failed. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #3247 by creating placeholder source/target facts if creating a relationship that is missing them. Out-of-the-box parsers will create relationships with both source and target facts (even if their traits and values are empty), but custom user-made parsers may not always create the actual corresponding fact objects. This change creates an additional guard-rail.
Type of change
How Has This Been Tested?
Modified an existing parser to skip creating a target fact object and verified the relationship was created correctly and that it shows up in the fact source for a test operation.
Checklist: