Skip to content

create placeholder facts if they're None when creating relationships #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clenk merged 3 commits into from
Jan 29, 2026
Merged

create placeholder facts if they're None when creating relationships #3248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
952c8f5
create placeholder facts if they're None when creating relationships
uruwhy Jan 28, 2026
b13d300
use relationship constructor to set default facts
uruwhy Jan 28, 2026
774136c
Merge branch 'master' into issue-3247
uruwhy Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/objects/secondclass/c_relationship.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import marshmallow as ma

from app.utility.base_object import BaseObject
from app.objects.secondclass.c_fact import FactSchema
from app.objects.secondclass.c_fact import Fact, FactSchema


class RelationshipSchema(ma.Schema):
Expand Down Expand Up @@ -68,8 +68,8 @@ def shorthand(self):

def __init__(self, source, edge=None, target=None, score=1, origin=None):
super().__init__()
self.source = source
self.source = source or Fact('', None)
self.edge = edge
self.target = target
self.target = target or Fact('', None)
self.score = score
self.origin = origin
Loading