Skip to content

hotfix(codec): support nanosecond timestamps in partition schema fingerprint #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
badalprasadsingh wants to merge 2 commits into from
Closed

hotfix(codec): support nanosecond timestamps in partition schema fingerprint #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b37662
fix: timestamp-ns
badalprasadsingh Sep 23, 2026
2cddd24
minor: lint
badalprasadsingh Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data_file_codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,10 @@ func writePartitionTypeFingerprint(key *strings.Builder, typ Type) error {
key.WriteByte('t')
case TimestampTzType:
key.WriteByte('z')
case TimestampNsType:
key.WriteByte('n')
case TimestampTzNsType:
key.WriteByte('N')
case UUIDType:
key.WriteByte('u')
case BooleanType:
Expand Down
35 changes: 33 additions & 2 deletions data_file_codec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,37 @@ func TestMarshalAvroEntryDecimalPartitionRoundTrip(t *testing.T) {
require.True(t, got.Equals(DecimalLiteral(want)))
}

func TestMarshalAvroEntryTimestampPartitionRoundTrip(t *testing.T) {
// Micro cases run first.
// A nano type sharing their schema-cache key would decode as Timestamp instead of TimestampNano.
for _, tc := range []struct {
typ Type
want any
}{
{TimestampType{}, Timestamp(1_700_000_000_000_000)},
{TimestampTzType{}, Timestamp(1_700_000_000_000_000)},
{TimestampNsType{}, TimestampNano(1_700_000_000_000_000_123)},
{TimestampTzNsType{}, TimestampNano(1_700_000_000_000_000_123)},
} {
t.Run(tc.typ.String(), func(t *testing.T) {
schema := NewSchema(0, NestedField{ID: 1, Name: "ts", Type: tc.typ})
spec := NewPartitionSpecID(1, PartitionField{SourceIDs: []int{1}, FieldID: 1000, Name: "ts", Transform: IdentityTransform{}})

path := "s3://bucket/ns/tbl/data/ts.parquet"
builder, err := NewDataFileBuilder(spec, EntryContentData, path, ParquetFile, map[int]any{1000: tc.want}, nil, nil, 1, 1024)
require.NoError(t, err)
df, ok := builder.Build().(*dataFile)
require.True(t, ok)

encoded, err := df.MarshalAvroEntry(spec, schema, 3)
require.NoError(t, err)
decoded, err := unmarshalAvroDataFileEntry(encoded, spec, schema, 3)
require.NoError(t, err)
require.Equal(t, tc.want, decoded.Partition()[1000])
})
}
}

// snapshotAvroFields returns a deep copy of every avro-tagged field on
// d, keyed by field name. Slices, maps, byte arrays, and pointer
// targets are reconstructed so the snapshot is fully independent of d
Expand Down Expand Up @@ -357,6 +388,8 @@ func TestManifestEntrySchemaForMatchesPartitionAvroShape(t *testing.T) {
TimeType{},
TimestampType{},
TimestampTzType{},
TimestampNsType{},
TimestampTzNsType{},
UUIDType{},
BooleanType{},
BinaryType{},
Expand Down Expand Up @@ -464,8 +497,6 @@ func TestManifestEntrySchemaForRejectsInvalidTypesAfterCacheHit(t *testing.T) {

for _, typ := range []Type{
unsupportedCodecPartitionType{},
TimestampNsType{},
TimestampTzNsType{},
VariantType{},
&StructType{}, &ListType{ElementID: 2, Element: Int64Type{}},
&MapType{KeyID: 2, KeyType: StringType{}, ValueID: 3, ValueType: Int64Type{}},
Expand Down
Loading