Mothership Rework Items - #8
Closed
SirChuckOfTheChuckles wants to merge 8 commits into
Closed
Conversation
Ziktofel
requested changes
Dec 8, 2025
Comment on lines
+1372
to
+1373
| CompatItemHolder(item_names.MOTHERSHIP_AIUR_VALOROUS_RESOLVE), | ||
| CompatItemHolder(item_names.MOTHERSHIP_PURIFIER_MOBILE_POWER_FIELD), |
There was a problem hiding this comment.
These alt variants weren't known before this API level, thus it's pointless to have compat items for them
SirChuckOfTheChuckles
changed the base branch from
sc2-next-0.6.4
to
sc2-next
December 21, 2025 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game-Data PR: archipelago-sc2/Archipelago-SC2-data#4
What is this fixing or adding?
Add new items for the Mothership and changed a few generation/logic checks to account for new Mothership item renames.
How was this tested?
Generated and loaded up a test world successfully; verified each item gave me what it should've properly.
If this makes graphical changes, please attach screenshots.