ci: key the browser cache on the Playwright version alone#182
Merged
Conversation
Hashing the whole version catalog meant any dependency bump paid the 60s cold browser install; the key now uses the Playwright version itself, so the cache only invalidates when the browsers actually change. Also answers the old inline comment wondering whether a smarter key exists.
The canary still carried the original key on reference-app/ build.gradle.kts — the earlier chromium-only change silently missed it because its text differed — so it kept the stale-cache bug: a Playwright bump would restore old browsers that PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD then refuses to replace. Now keyed on the Playwright version like the CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashing the whole catalog meant any dependency bump paid the 60s cold browser install; the key now uses the Playwright version itself. Also fixes the canary, which had silently kept the original build.gradle.kts-based key when the chromium-only change landed — it still carried the stale-cache bug (a Playwright bump would restore old browsers that PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD refuses to replace).
🤖 Generated with Claude Code