Skip to content

ci: key the browser cache on the Playwright version alone #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ardetrick merged 2 commits into from
Jul 5, 2026
Merged

ci: key the browser cache on the Playwright version alone #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f9550f
ci: key the browser cache on the Playwright version alone
ardetrick Jul 5, 2026
6730604
ci: fix the canary's browser cache key too
ardetrick Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,18 @@ jobs:
distribution: 'temurin'
- name: Set up Gradle
uses: gradle/actions/setup-gradle@v6
# Key the browser cache on the Playwright version alone so unrelated dependency
# bumps in the catalog do not trigger a browser reinstall.
- name: Resolve Playwright version
id: playwright-version
run: echo "version=$(grep -m1 '^playwright = ' gradle/libs.versions.toml | cut -d'"' -f2)" >> "$GITHUB_OUTPUT"
- name: Setup ms-playwright cache
id: setup-ms-playwright-cache
uses: actions/cache@v6
with:
# Some dependencies are downloaded to this directory
path: /home/runner/.cache/ms-playwright
# There probably is a smarter way to create this key but this should be ok for now.
key: ms-playwright-chromium-${{ runner.os }}-${{ hashFiles('gradle/libs.versions.toml') }}
key: ms-playwright-chromium-${{ runner.os }}-${{ steps.playwright-version.outputs.version }}
- name: Install Playwright Dependencies
if: steps.setup-ms-playwright-cache.outputs.cache-hit != 'true'
# Chromium only — the only browser the tests use; one Gradle invocation.
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/upstream-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,17 @@ jobs:
distribution: 'temurin'
- name: Set up Gradle
uses: gradle/actions/setup-gradle@v6
# Key the browser cache on the Playwright version alone so unrelated dependency
# bumps do not trigger a browser reinstall.
- name: Resolve Playwright version
id: playwright-version
run: echo "version=$(grep -m1 '^playwright = ' gradle/libs.versions.toml | cut -d'"' -f2)" >> "$GITHUB_OUTPUT"
- name: Setup ms-playwright cache
id: setup-ms-playwright-cache
uses: actions/cache@v6
with:
path: /home/runner/.cache/ms-playwright
key: ms-playwright-cache-${{ runner.os }}-${{ hashFiles('reference-app/build.gradle.kts') }}
key: ms-playwright-chromium-${{ runner.os }}-${{ steps.playwright-version.outputs.version }}
- name: Install Playwright Dependencies
if: steps.setup-ms-playwright-cache.outputs.cache-hit != 'true'
# Chromium only — the only browser the tests use; one Gradle invocation.
Expand Down