fix(a11y): label inventory selects + fix logo button accessible name (P3b)#213
Merged
Conversation
Lighthouse accessibility audit of the live inventory page (score 91): two real WCAG failures (the 6 color-contrast flags are false positives — white hero text over a dark background image Lighthouse can't measure; verified by screenshot). - select-name: the sort <select> (and the beds/baths/type filter selects, whose visible labels weren't programmatically associated) had no accessible name. Added aria-labels. - label-content-name-mismatch: the header logo button overrode its visible text 'Texas Home Outlet' with aria-label='Go to home page'. Now the aria-label contains the visible business name (WCAG 2.5.3). Build + eslint clean; 50 vitest pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Lighthouse on /contact: two text-xs helper lines (business hours, char count) used text-gray-400 (#99a1af) on white = 2.6:1, below WCAG 4.5:1. Bumped to text-gray-500 (~4.6:1). (Header logo name-mismatch on this page is already fixed by the logo aria-label change.) Follow-up flagged: add a <main> landmark. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Lighthouse on /appointments + /contact flagged text-xs text-gray-400 (#99a1af on light = ~2.5:1, below WCAG 4.5:1) across customer-facing components. Bump to text-gray-500 (~4.6:1) in PropertyCard (listing cards), Appointments, ReportIssue, and ContentPage. All on light backgrounds, so darker grey only improves contrast. Admin-only pages (AdStudio/DocumentCenter/PhotoManager) + the <main> landmark are flagged as follow-ups. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live Lighthouse a11y audit (91/100). Fixes the 2 real WCAG failures: unlabeled inventory selects (sort + beds/baths/type) and the header logo button name-mismatch (aria-label now contains the visible 'Texas Home Outlet'). The 6 color-contrast flags are confirmed false positives (white hero text over a dark bg image — verified by screenshot). Build + eslint clean; 50 vitest.