Skip to content

fix(a11y): label inventory selects + fix logo button accessible name (P3b) #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arigatoexpress merged 3 commits into from
Jun 20, 2026
Merged

fix(a11y): label inventory selects + fix logo button accessible name (P3b) #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eac932
fix(a11y): label inventory selects + fix logo button name (P3b)
arigatoexpress Jun 20, 2026
4a8c33c
fix(a11y): darken Contact helper text for contrast (P3b)
arigatoexpress Jun 20, 2026
3f67403
fix(a11y): darken small grey text site-wide for contrast (P3b)
arigatoexpress Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function NavBar({
className="flex items-center space-x-2.5 cursor-pointer group"
onClick={() => navigateTo('inventory')}
role="button"
aria-label="Go to home page"
aria-label={`${BUSINESS_NAME} — home`}
>
<Home className="h-6 w-6 text-[var(--cp-accent)] group-hover:drop-shadow-[0_2px_8px_rgba(80,29,29,0.35)] transition" />
<h1 className="text-base font-bold tracking-tight text-[var(--cp-text)]">
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ContentPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ContentPage = ({ title, subtitle, children, onBack }) => (
{children}
</article>

<p className="text-center text-xs text-gray-400 mt-8">
<p className="text-center text-xs text-gray-500 mt-8">
© {new Date().getFullYear()} {BUSINESS_NAME}. All rights reserved.
</p>
</div>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/PropertyCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ const PropertyCard = ({ property, onToggleCompare, isSelected }) => {
<Bed size={14} className="mr-1 text-gray-400" />
<span className="font-semibold text-sm">{specs.beds}</span>
</div>
<span className="text-xs text-gray-400">Beds</span>
<span className="text-xs text-gray-500">Beds</span>
</div>
);
}
Expand All @@ -318,7 +318,7 @@ const PropertyCard = ({ property, onToggleCompare, isSelected }) => {
<Bath size={14} className="mr-1 text-gray-400" />
<span className="font-semibold text-sm">{specs.baths}</span>
</div>
<span className="text-xs text-gray-400">Baths</span>
<span className="text-xs text-gray-500">Baths</span>
</div>
);
}
Expand All @@ -329,7 +329,7 @@ const PropertyCard = ({ property, onToggleCompare, isSelected }) => {
<Maximize size={14} className="mr-1 text-gray-400" />
<span className="font-semibold text-sm">{specs.sq_ft.toLocaleString()}</span>
</div>
<span className="text-xs text-gray-400">Sq Ft</span>
<span className="text-xs text-gray-500">Sq Ft</span>
</div>
);
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ReportIssue.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default function ReportIssue() {
autoFocus
/>
<div className="flex items-center justify-between mt-3">
<span className="text-xs text-gray-400">
<span className="text-xs text-gray-500">
Page: {window.location.pathname}
</span>
<button
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Appointments.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const CalendarGrid = ({ selectedDate, onSelect }) => {
<div className="grid grid-cols-7 gap-1">
{cells}
</div>
<p className="text-xs text-gray-400 mt-4 text-center">
<p className="text-xs text-gray-500 mt-4 text-center">
Dimmed dates are unavailable — past days and dates more than 30 days out can&apos;t be booked online. Call {BUSINESS_PHONE} for dates further ahead.
</p>
</div>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/pages/Contact.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const Contact = ({ onBack }) => {
<div>
<h3 className="text-lg font-bold text-gray-900">Call Us Directly</h3>
<a href={`tel:${BUSINESS_PHONE_RAW}`} className="text-gray-600 mt-1 block hover:text-blue-600 transition-colors">{BUSINESS_PHONE}</a>
<p className="text-xs text-gray-400 mt-1">{BUSINESS_HOURS}</p>
<p className="text-xs text-gray-500 mt-1">{BUSINESS_HOURS}</p>
</div>
</div>
</div>
Expand Down Expand Up @@ -190,7 +190,7 @@ const Contact = ({ onBack }) => {
placeholder="Tell us about the home you are looking for..."
maxLength={2000}
></textarea>
<p className="text-xs text-gray-400 text-right mt-1">{formData.message.length}/2000</p>
<p className="text-xs text-gray-500 text-right mt-1">{formData.message.length}/2000</p>
</div>
{submitError && (
<p role="alert" className="text-sm text-red-600 bg-red-50 p-3 rounded-lg">{submitError}</p>
Expand Down
7 changes: 4 additions & 3 deletions frontend/src/pages/InventoryBrowse.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,7 @@ export default function InventoryBrowse({ adminAuthed = false, onAskTex, onCreat
value={sortBy}
onChange={(e) => setSortBy(e.target.value)}
className={CHIP_INPUT}
aria-label="Sort homes"
>
{SORT_OPTIONS.map(opt => (
<option key={opt.value} value={opt.value}>{opt.label}</option>
Expand Down Expand Up @@ -882,7 +883,7 @@ export default function InventoryBrowse({ adminAuthed = false, onAskTex, onCreat
<label className="text-xs font-semibold text-[var(--cp-muted)] uppercase tracking-wide flex items-center gap-1">
<Bed size={14} /> Bedrooms
</label>
<select className={CHIP_INPUT} value={filters.beds} onChange={e => setFilters(f => ({ ...f, beds: e.target.value }))}>
<select aria-label="Bedrooms" className={CHIP_INPUT} value={filters.beds} onChange={e => setFilters(f => ({ ...f, beds: e.target.value }))}>
<option value="">Any</option>
<option value="1">1+</option>
<option value="2">2+</option>
Expand All @@ -894,7 +895,7 @@ export default function InventoryBrowse({ adminAuthed = false, onAskTex, onCreat
<label className="text-xs font-semibold text-[var(--cp-muted)] uppercase tracking-wide flex items-center gap-1">
<Bath size={14} /> Bathrooms
</label>
<select className={CHIP_INPUT} value={filters.baths} onChange={e => setFilters(f => ({ ...f, baths: e.target.value }))}>
<select aria-label="Bathrooms" className={CHIP_INPUT} value={filters.baths} onChange={e => setFilters(f => ({ ...f, baths: e.target.value }))}>
<option value="">Any</option>
<option value="1">1+</option>
<option value="2">2+</option>
Expand All @@ -905,7 +906,7 @@ export default function InventoryBrowse({ adminAuthed = false, onAskTex, onCreat
<label className="text-xs font-semibold text-[var(--cp-muted)] uppercase tracking-wide flex items-center gap-1">
<Home size={14} /> Type
</label>
<select className={CHIP_INPUT} value={filters.classification} onChange={e => setFilters(f => ({ ...f, classification: e.target.value }))}>
<select aria-label="Home type" className={CHIP_INPUT} value={filters.classification} onChange={e => setFilters(f => ({ ...f, classification: e.target.value }))}>
<option value="">Any</option>
<option value="Single Wide">Single Wide</option>
<option value="Double Wide">Double Wide</option>
Expand Down
Loading